From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
"David S. Miller" <davem@davemloft.net>,
Marcin Wojtas <mw@semihalf.com>,
Vladimir Zapolskiy <vz@mleia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: sram: remove useless #ifdef
Date: Tue, 29 Nov 2016 20:41:54 +0100 [thread overview]
Message-ID: <20161129194154.GA27810@kroah.com> (raw)
In-Reply-To: <20161122143103.1835294-1-arnd@arndb.de>
On Tue, Nov 22, 2016 at 03:30:54PM +0100, Arnd Bergmann wrote:
> A recent patch added a new function that is now unused whenever
> CONFIG_OF is disabled:
>
> drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function]
>
> There is actually no reason for the #ifdef, because the driver
> currently cannot be used in a meaningful way without CONFIG_OF,
> and there is no compile-time dependency.
>
> Removing that #ifdef and the respective of_match_ptr() avoids the
> warning and simplifies the driver slightly.
>
> Fixes: 2ae2e28852f2 ("misc: sram: add Atmel securam support")
What tree is this commit in? I can't seem to find it in one of mine, am
I just missing it somewhere?
thanks,
greg "I have too many git trees" k-h
next prev parent reply other threads:[~2016-11-29 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 14:30 [PATCH] misc: sram: remove useless #ifdef Arnd Bergmann
2016-11-22 17:47 ` Vladimir Zapolskiy
2016-11-22 17:59 ` Alexandre Belloni
2016-11-30 14:44 ` Arnd Bergmann
2016-11-29 19:41 ` Greg Kroah-Hartman [this message]
2016-11-29 19:54 ` Alexandre Belloni
2016-11-29 20:01 ` Greg Kroah-Hartman
2016-11-29 23:30 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129194154.GA27810@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox