From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756200AbcK2Tly (ORCPT ); Tue, 29 Nov 2016 14:41:54 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37380 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753974AbcK2Tlp (ORCPT ); Tue, 29 Nov 2016 14:41:45 -0500 Date: Tue, 29 Nov 2016 20:41:54 +0100 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Alexandre Belloni , "David S. Miller" , Marcin Wojtas , Vladimir Zapolskiy , linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: sram: remove useless #ifdef Message-ID: <20161129194154.GA27810@kroah.com> References: <20161122143103.1835294-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161122143103.1835294-1-arnd@arndb.de> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2016 at 03:30:54PM +0100, Arnd Bergmann wrote: > A recent patch added a new function that is now unused whenever > CONFIG_OF is disabled: > > drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function] > > There is actually no reason for the #ifdef, because the driver > currently cannot be used in a meaningful way without CONFIG_OF, > and there is no compile-time dependency. > > Removing that #ifdef and the respective of_match_ptr() avoids the > warning and simplifies the driver slightly. > > Fixes: 2ae2e28852f2 ("misc: sram: add Atmel securam support") What tree is this commit in? I can't seem to find it in one of mine, am I just missing it somewhere? thanks, greg "I have too many git trees" k-h