* [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers
@ 2016-11-25 9:50 Robin van der Gracht
2016-11-29 19:42 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Robin van der Gracht @ 2016-11-25 9:50 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Linus Walleij, Arnd Bergmann, Miguel Ojeda Sandonis, linux-kernel,
Robin van der Gracht
This selects the respective helpers required in addition to the one
Arnd Bergmann pointer out earlier.
Signed-off-by: Robin van der Gracht <robin@protonic.nl>
---
This is a responce to https://lkml.org/lkml/2016/11/25/66
This patch complements the changes Arnd submitted earlier.
drivers/auxdisplay/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index b8bbfc6..4ef4c5c 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -132,6 +132,9 @@ config HT16K33
tristate "Holtek Ht16K33 LED controller with keyscan"
depends on FB && OF && I2C && INPUT
select FB_SYS_FOPS
+ select FB_CFB_FILLRECT
+ select FB_CFB_COPYAREA
+ select FB_CFB_IMAGEBLIT
select INPUT_MATRIXKMAP
select FB_BACKLIGHT
help
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers
2016-11-25 9:50 [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers Robin van der Gracht
@ 2016-11-29 19:42 ` Greg Kroah-Hartman
2016-11-29 19:55 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-11-29 19:42 UTC (permalink / raw)
To: Robin van der Gracht
Cc: Linus Walleij, Arnd Bergmann, Miguel Ojeda Sandonis, linux-kernel
On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wrote:
> This selects the respective helpers required in addition to the one
> Arnd Bergmann pointer out earlier.
>
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
> This is a responce to https://lkml.org/lkml/2016/11/25/66
> This patch complements the changes Arnd submitted earlier.
>
> drivers/auxdisplay/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index b8bbfc6..4ef4c5c 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -132,6 +132,9 @@ config HT16K33
> tristate "Holtek Ht16K33 LED controller with keyscan"
> depends on FB && OF && I2C && INPUT
> select FB_SYS_FOPS
> + select FB_CFB_FILLRECT
> + select FB_CFB_COPYAREA
> + select FB_CFB_IMAGEBLIT
> select INPUT_MATRIXKMAP
> select FB_BACKLIGHT
> help
What tree is this patch against?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers
2016-11-29 19:42 ` Greg Kroah-Hartman
@ 2016-11-29 19:55 ` Arnd Bergmann
2016-11-29 20:04 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2016-11-29 19:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Robin van der Gracht, Linus Walleij, Miguel Ojeda Sandonis,
linux-kernel
On Tuesday, November 29, 2016 8:42:47 PM CET Greg Kroah-Hartman wrote:
> On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wrote:
> > This selects the respective helpers required in addition to the one
> > Arnd Bergmann pointer out earlier.
> >
> > Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> > ---
> > This is a responce to https://lkml.org/lkml/2016/11/25/66
> > This patch complements the changes Arnd submitted earlier.
> >
> > drivers/auxdisplay/Kconfig | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > index b8bbfc6..4ef4c5c 100644
> > --- a/drivers/auxdisplay/Kconfig
> > +++ b/drivers/auxdisplay/Kconfig
> > @@ -132,6 +132,9 @@ config HT16K33
> > tristate "Holtek Ht16K33 LED controller with keyscan"
> > depends on FB && OF && I2C && INPUT
> > select FB_SYS_FOPS
> > + select FB_CFB_FILLRECT
> > + select FB_CFB_COPYAREA
> > + select FB_CFB_IMAGEBLIT
> > select INPUT_MATRIXKMAP
> > select FB_BACKLIGHT
> > help
>
> What tree is this patch against?
>
> thanks,
>
> greg k-h
>
It's on top of my patch "auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS"
from a few days ago. I guess Robin expected you to have picked that
up, while you expected him to combine it with the new changes.
Robin, I think it's easier if you send the combined patch and
add "Reported-by: Arnd Bergmann <arnd@arndb.de>", as Greg has
probably already droppped my earlier patch from his queue.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers
2016-11-29 19:55 ` Arnd Bergmann
@ 2016-11-29 20:04 ` Greg Kroah-Hartman
2016-11-30 7:57 ` Robin van der Gracht
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-11-29 20:04 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Robin van der Gracht, Linus Walleij, Miguel Ojeda Sandonis,
linux-kernel
On Tue, Nov 29, 2016 at 08:55:50PM +0100, Arnd Bergmann wrote:
> On Tuesday, November 29, 2016 8:42:47 PM CET Greg Kroah-Hartman wrote:
> > On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wrote:
> > > This selects the respective helpers required in addition to the one
> > > Arnd Bergmann pointer out earlier.
> > >
> > > Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> > > ---
> > > This is a responce to https://lkml.org/lkml/2016/11/25/66
> > > This patch complements the changes Arnd submitted earlier.
> > >
> > > drivers/auxdisplay/Kconfig | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > > index b8bbfc6..4ef4c5c 100644
> > > --- a/drivers/auxdisplay/Kconfig
> > > +++ b/drivers/auxdisplay/Kconfig
> > > @@ -132,6 +132,9 @@ config HT16K33
> > > tristate "Holtek Ht16K33 LED controller with keyscan"
> > > depends on FB && OF && I2C && INPUT
> > > select FB_SYS_FOPS
> > > + select FB_CFB_FILLRECT
> > > + select FB_CFB_COPYAREA
> > > + select FB_CFB_IMAGEBLIT
> > > select INPUT_MATRIXKMAP
> > > select FB_BACKLIGHT
> > > help
> >
> > What tree is this patch against?
> >
> > thanks,
> >
> > greg k-h
> >
>
> It's on top of my patch "auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS"
> from a few days ago. I guess Robin expected you to have picked that
> up, while you expected him to combine it with the new changes.
>
> Robin, I think it's easier if you send the combined patch and
> add "Reported-by: Arnd Bergmann <arnd@arndb.de>", as Greg has
> probably already droppped my earlier patch from his queue.
Yes, it's not in my queue anymore.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers
2016-11-29 20:04 ` Greg Kroah-Hartman
@ 2016-11-30 7:57 ` Robin van der Gracht
0 siblings, 0 replies; 5+ messages in thread
From: Robin van der Gracht @ 2016-11-30 7:57 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arnd Bergmann, Linus Walleij, Miguel Ojeda Sandonis, linux-kernel
On Tue, 29 Nov 2016 21:04:30 +0100
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Tue, Nov 29, 2016 at 08:55:50PM +0100, Arnd Bergmann wrote:
> > On Tuesday, November 29, 2016 8:42:47 PM CET Greg Kroah-Hartman wrote:
> > > On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wrote:
> > > > This selects the respective helpers required in addition to the one
> > > > Arnd Bergmann pointer out earlier.
> > > >
> > > > Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> > > > ---
> > > > This is a responce to https://lkml.org/lkml/2016/11/25/66
> > > > This patch complements the changes Arnd submitted earlier.
> > > >
> > > > drivers/auxdisplay/Kconfig | 3 +++
> > > > 1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > > > index b8bbfc6..4ef4c5c 100644
> > > > --- a/drivers/auxdisplay/Kconfig
> > > > +++ b/drivers/auxdisplay/Kconfig
> > > > @@ -132,6 +132,9 @@ config HT16K33
> > > > tristate "Holtek Ht16K33 LED controller with keyscan"
> > > > depends on FB && OF && I2C && INPUT
> > > > select FB_SYS_FOPS
> > > > + select FB_CFB_FILLRECT
> > > > + select FB_CFB_COPYAREA
> > > > + select FB_CFB_IMAGEBLIT
> > > > select INPUT_MATRIXKMAP
> > > > select FB_BACKLIGHT
> > > > help
> > >
> > > What tree is this patch against?
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > It's on top of my patch "auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS"
> > from a few days ago. I guess Robin expected you to have picked that
> > up, while you expected him to combine it with the new changes.
> >
> > Robin, I think it's easier if you send the combined patch and
> > add "Reported-by: Arnd Bergmann <arnd@arndb.de>", as Greg has
> > probably already droppped my earlier patch from his queue.
>
> Yes, it's not in my queue anymore.
>
> thanks,
>
> greg k-h
I'll create a new patch.
Regards,
Robin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-30 7:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-25 9:50 [PATCH] auxdisplay: ht16k33: select required CONFIG_FB_CFB_* helpers Robin van der Gracht
2016-11-29 19:42 ` Greg Kroah-Hartman
2016-11-29 19:55 ` Arnd Bergmann
2016-11-29 20:04 ` Greg Kroah-Hartman
2016-11-30 7:57 ` Robin van der Gracht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox