From: Stephen Boyd <sboyd@codeaurora.org>
To: Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>
Cc: mturquette@baylibre.com, orson.zhai@spreadtrum.com,
ben.li@spreadtrum.com, baolin.wang@spreadtrum.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: Register clkdev after setup of fixed-rate and fixed-factor clocks
Date: Tue, 29 Nov 2016 13:10:54 -0800 [thread overview]
Message-ID: <20161129211054.GD6095@codeaurora.org> (raw)
In-Reply-To: <20161124073948.GA12946@spreadtrum.com>
On 11/24, Xiaolong Zhang wrote:
> On 三, 11月 23, 2016 at 04:38:33下午 -0800, Stephen Boyd wrote:
>
> > We're really off track now though. Can you please point to some
> > code that needs this change? If we're using DT then we should be
> > able to use the of_clk_*() path to find the clk.
> >
>
> Actually, the requirement is raised by our GPU driver. In the
> early stage of the GPU DT driver, the GPU driver use the
> clk_get(NULL, con_id) to get the clock instance for compatible
> with non-DT GPU driver. The new driver have used the of_clk_get()
> instead of the clk_get. And we reserved the modification in clock.
>
Ok the non-DT version of the GPU driver should be modified to
call clk_get() and pass in the device. The con_id argument there
should be something specific to the GPU device, and not a global
name of a clock on the system. When the clkdev lookup is
populated on the non-DT board make sure to set the dev_id string
to match the device name of the GPU device.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-29 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 11:13 [PATCH] clk: Register clkdev after setup of fixed-rate and fixed-factor clocks Orson Zhai
2016-10-20 23:01 ` Stephen Boyd
2016-10-22 8:14 ` Xiaolong Zhang
2016-10-25 20:40 ` Stephen Boyd
2016-11-12 5:19 ` Xiaolong Zhang
2016-11-24 0:38 ` Stephen Boyd
2016-11-24 7:39 ` Xiaolong Zhang
2016-11-29 21:10 ` Stephen Boyd [this message]
2016-12-03 5:46 ` Xiaolong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129211054.GD6095@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=baolin.wang@spreadtrum.com \
--cc=ben.li@spreadtrum.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=orson.zhai@spreadtrum.com \
--cc=xiaolong.zhang@spreadtrum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).