From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933233AbcK3MCb (ORCPT ); Wed, 30 Nov 2016 07:02:31 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45490 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933030AbcK3MCX (ORCPT ); Wed, 30 Nov 2016 07:02:23 -0500 Date: Wed, 30 Nov 2016 13:02:32 +0100 From: "gregkh@linuxfoundation.org" To: Atul Raj Cc: Viresh Kumar , "mathias.nyman@linux.intel.com" , "stern@rowland.harvard.edu" , "baolu.lu@linux.intel.com" , "oneukum@suse.com" , "hansy@nvidia.com" , "alcooperx@gmail.com" , "atulraj.nith@gmail.com" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Pankaj Singh Subject: Re: [PATCH] usb:hub: readibility and consistency in coding style Message-ID: <20161130120232.GA8761@kroah.com> References: <20161130063238epcms5p5b82d469df3d562bdfb1b6ca53ea1e226@epcms5p5> <20161130115139epcms5p3fb0520cf6cabcf69e470be63463a46d1@epcms5p3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161130115139epcms5p3fb0520cf6cabcf69e470be63463a46d1@epcms5p3> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2016 at 11:51:39AM +0000, Atul Raj wrote: > It is suggested to keep braces if there is a comment in if case as > comment also takes a line. > --- > drivers/usb/core/hub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Ok, this is getting to be a joke. Take a few days off, relax, then try to send a patch that works to yourself first, and run it through scripts/checkpatch.pl to verify that it really is correct. Hint, this one isn't at all. Then, maybe you should start doing some work on drivers/staging/ first, which is where new developers should start out to work out all of these issues so you don't bother the other developers who are working on adding new features and fixing bugs. Also, why are you including a ton of people who have nothing to do with usb patches on this one? good luck, greg k-h