From: Greg KH <gregkh@linuxfoundation.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH v2] drivers/usb: use READ_ONCE instead of deprecated ACCESS_ONCE
Date: Wed, 30 Nov 2016 15:23:11 +0100 [thread overview]
Message-ID: <20161130142311.GA24288@kroah.com> (raw)
In-Reply-To: <20161130135054.GB25118@linux-80c1.suse>
On Wed, Nov 30, 2016 at 05:50:54AM -0800, Davidlohr Bueso wrote:
> With the new standardized functions, we can replace all ACCESS_ONCE()
> calls across relevant drivers/usb/.
>
> ACCESS_ONCE() does not work reliably on non-scalar types. For example
> gcc 4.6 and 4.7 might remove the volatile tag for such accesses during
> the SRA (scalar replacement of aggregates) step:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
>
> Update the new calls regardless of if it is a scalar type, this is
> cleaner than having three alternatives.
>
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
> drivers/usb/class/cdc-wdm.c | 2 +-
> drivers/usb/core/devio.c | 2 +-
> drivers/usb/core/sysfs.c | 4 ++--
> drivers/usb/gadget/udc/gr_udc.c | 4 ++--
> drivers/usb/host/ohci-hcd.c | 2 +-
> drivers/usb/host/uhci-hcd.h | 4 ++--
> 6 files changed, 9 insertions(+), 9 deletions(-)
Same comment on your driver base patch, what changed from v1?
prev parent reply other threads:[~2016-11-30 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 19:54 [PATCH] drivers/usb: use READ_ONCE instead of deprecated ACCESS_ONCE Davidlohr Bueso
2016-11-20 9:39 ` Greg KH
2016-11-20 12:11 ` Mark Rutland
2016-11-20 16:09 ` Davidlohr Bueso
2016-11-21 7:15 ` Greg KH
2016-11-29 19:24 ` Greg KH
2016-11-30 13:50 ` [PATCH v2] " Davidlohr Bueso
2016-11-30 14:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130142311.GA24288@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox