From: Brian Norris <computersforpeace@gmail.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Luis Henriques <henrix@camandro.org>,
David Woodhouse <dwmw2@infradead.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: maps: add missing iounmap() in error path
Date: Wed, 30 Nov 2016 18:32:50 -0800 [thread overview]
Message-ID: <20161201023250.GL77253@google.com> (raw)
In-Reply-To: <f933f0ff-2ba6-ac7b-e5b8-d7a4d04c0aa9@gmail.com>
On Fri, Nov 25, 2016 at 03:18:09PM +0100, Marek Vasut wrote:
> On 11/24/2016 12:40 AM, Luis Henriques wrote:
> > This patch was triggered by the following Coccinelle error:
> >
> > ./drivers/mtd/maps/sc520cdp.c:246:3-9: \
> > ERROR: missing iounmap; ioremap on line 242 \
> > and execution via conditional on line 244
> >
> > Since do_map_probe() is also invoked in this loop, it is also necessary to
> > map_destroy() any initialised struct mtd_info.
> >
> > Signed-off-by: Luis Henriques <henrix@camandro.org>
> > ---
> > Changes since v1:
> > * Changes according to Brian Norris review:
> > - Ensure sc520cdp_map[0].virt is unmaped when needed
> > - Use a for loop instead of an 'if (i)'
> > - Prevent double-iounmap
> > * Added map_destroy() in the cleanup
> >
> > drivers/mtd/maps/sc520cdp.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
...
> Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
Applied to l2-mtd.git
prev parent reply other threads:[~2016-12-01 2:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 22:50 [PATCH] mtd: maps: add missing iounmap() in error path Luis Henriques
2016-11-20 21:13 ` Marek Vasut
2016-11-22 19:21 ` Brian Norris
2016-11-23 15:22 ` Luis Henriques
2016-11-23 23:40 ` [PATCH v2] " Luis Henriques
2016-11-25 14:18 ` Marek Vasut
2016-12-01 2:32 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201023250.GL77253@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=henrix@camandro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).