From: Vinod Koul <vinod.koul@intel.com>
To: Pan Bian <bianpan2016@163.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dma: ioat: set error code on failures
Date: Fri, 2 Dec 2016 16:02:25 +0530 [thread overview]
Message-ID: <20161202103225.GM6408@localhost> (raw)
In-Reply-To: <1480576212-26518-1-git-send-email-bianpan2016@163.com>
On Thu, Dec 01, 2016 at 03:10:12PM +0800, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188591. In function
> ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the
> value of return variable err is 0 (indicates no error). As a result, the
> return value may be inconsistent with the execution status. This patch
> fixes the bug by assigning -ENOMEM to err on the error path.
Please describe the fix you are doing. For Bugzilla you can use Fixes tag
Also add the correct subsystem tag, so the changelog can look like:
dmaengine: ioat: set error code on failures
In ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the
value of return variable err is 0 ...
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188591
Fixes: Commit you fixes
..
So please update the changelog and resend with Acks collected
--
~Vinod
prev parent reply other threads:[~2016-12-02 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 7:10 [PATCH 1/1] dma: ioat: set error code on failures Pan Bian
2016-12-01 16:46 ` Dave Jiang
2016-12-02 10:32 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202103225.GM6408@localhost \
--to=vinod.koul@intel.com \
--cc=Julia.Lawall@lip6.fr \
--cc=bianpan2016@163.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox