From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]
Date: Sun, 4 Dec 2016 04:00:33 +0000 [thread overview]
Message-ID: <20161204040026.GA32055@ZenIV.linux.org.uk> (raw)
In-Reply-To: <147986255194.19139.9583434946564699577.stgit@warthog.procyon.org.uk>
On Wed, Nov 23, 2016 at 12:55:51AM +0000, David Howells wrote:
> -int vfs_getattr_nosec(struct path *path, struct kstat *stat)
> +int vfs_xgetattr_nosec(struct path *path, struct kstat *stat)
const struct path *, please. Especially since we feed &file->f_path to
it. And yes, I realize that the same applies to vfs_getattr() in the
current tree.
> +int vfs_xgetattr(struct path *path, struct kstat *stat)
Ditto.
> +int vfs_getattr(struct path *path, struct kstat *stat)
Again.
> +#define __put_timestamp(kts, uts) ( \
> + __put_user(kts.tv_sec, uts.tv_sec ) || \
> + __put_user(kts.tv_nsec, uts.tv_nsec ) || \
> + __put_user(0, uts.__reserved ))
static inline.
> +#define KSTAT_ATTR_FS_IOC_FLAGS 0x00000874 /* Attrs corresponding to FS_*_FL flags */
Err... An explicit hex constant?
next prev parent reply other threads:[~2016-12-04 4:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 0:55 [RFC][PATCH 0/4] Enhanced file stat system call [ver #3] David Howells
2016-11-23 0:55 ` [PATCH 1/4] statx: Add a system call to make enhanced file info available " David Howells
2016-11-23 8:37 ` Michael Kerrisk (man-pages)
2016-11-23 22:42 ` Andreas Dilger
2016-11-23 22:57 ` Andreas Dilger
2016-11-24 8:13 ` Michael Kerrisk (man-pages)
2016-11-24 2:08 ` Andreas Dilger
2016-11-24 7:27 ` David Howells
2016-12-04 4:00 ` Al Viro [this message]
2016-12-04 4:38 ` Al Viro
2016-12-04 16:05 ` Al Viro
2016-12-05 15:37 ` David Howells
2016-12-04 17:33 ` Al Viro
2016-12-05 14:49 ` Miklos Szeredi
2016-11-23 0:55 ` [PATCH 2/4] statx: Ext4: Return enhanced file attributes " David Howells
2016-11-23 17:59 ` Andreas Dilger
2016-11-23 0:56 ` [PATCH 3/4] statx: NFS: " David Howells
2016-11-23 0:56 ` [PATCH 4/4] statx: AFS: " David Howells
2016-11-24 2:06 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161204040026.GA32055@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox