From: Dan Carpenter <dan.carpenter@oracle.com>
To: Fernando Apesteguia <fernando.apesteguia@gmail.com>
Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters
Date: Mon, 5 Dec 2016 23:51:16 +0300 [thread overview]
Message-ID: <20161205205116.GA31322@mwanda> (raw)
In-Reply-To: <1480706029-28267-1-git-send-email-fernando.apesteguia@gmail.com>
On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote:
> For the first lines of the patch, I opted to create a small function
> instead of breaking the the line in a weird way.
These first ones are the nice.
> @@ -2511,13 +2516,15 @@ static int dgnc_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
> if (ch->ch_tun.un_flags & (UN_LOW | UN_EMPTY)) {
> ch->ch_tun.un_flags &=
> ~(UN_LOW | UN_EMPTY);
> - wake_up_interruptible(&ch->ch_tun.un_flags_wait);
> + wake_up_interruptible(&ch->ch_tun
> + .un_flags_wait);
Ugh... No. Don't do this. Just let it go over 80 characters. Ignore
the warning.
regards,
dan carpenter
next prev parent reply other threads:[~2016-12-05 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 19:13 [PATCH] staging: dgnc: Fix lines longer than 80 characters Fernando Apesteguia
2016-12-03 8:51 ` Greg KH
2016-12-03 9:56 ` Fernando Apesteguia
2016-12-03 10:11 ` Greg KH
2016-12-04 19:06 ` Fernando Apesteguia
2016-12-05 20:51 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-28 17:20 Fernando Apesteguia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205205116.GA31322@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=fernando.apesteguia@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox