From: Dan Carpenter <dan.carpenter@oracle.com>
To: Juergen Gross <jgross@suse.com>
Cc: Quentin Lambert <lambert.quentin@gmail.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xen-scsifront: Add a missing call to kfree
Date: Mon, 5 Dec 2016 23:53:48 +0300 [thread overview]
Message-ID: <20161205205348.GA31465@mwanda> (raw)
In-Reply-To: <1320a162-dc36-5833-a746-367134dae5e7@suse.com>
On Mon, Nov 21, 2016 at 07:01:36AM +0100, Juergen Gross wrote:
> On 19/11/16 19:22, Quentin Lambert wrote:
> > Most error branches following the call to kmalloc contain
> > a call to kfree. This patch add these calls where they are
> > missing.
> >
> > This issue was found with Hector.
> >
> > Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
>
> Nice catch. I think this will need some more work, I'll do a
> follow-on patch.
>
The error handling is really weird. Could you send your follow on to
this thread?
regards,
dan carpenter
next prev parent reply other threads:[~2016-12-05 20:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 18:22 [PATCH] xen-scsifront: Add a missing call to kfree Quentin Lambert
2016-11-21 6:01 ` Juergen Gross
2016-11-22 3:40 ` Martin K. Petersen
2016-11-22 5:19 ` Juergen Gross
2016-11-25 21:28 ` Dan Carpenter
2016-11-29 10:50 ` [PATCH] xen/scsifront: don't advance ring request pointer in case of error Juergen Gross
2016-11-29 11:14 ` [Xen-devel] " Jan Beulich
[not found] ` <583D712F0200007800123283@suse.com>
2016-11-29 11:19 ` Juergen Gross
2016-11-29 11:28 ` David Vrabel
2016-11-29 11:33 ` Juergen Gross
2016-11-29 11:40 ` Jan Beulich
[not found] ` <583D772D02000078001232DD@suse.com>
2016-11-29 12:33 ` Juergen Gross
2016-12-02 6:10 ` [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready Juergen Gross
2016-12-02 6:13 ` Juergen Gross
2016-12-02 6:15 ` Juergen Gross
2016-12-05 15:32 ` Boris Ostrovsky
2016-12-05 15:35 ` Juergen Gross
2016-12-08 14:56 ` Boris Ostrovsky
2016-12-09 10:13 ` Juergen Gross
2016-12-05 20:53 ` Dan Carpenter [this message]
2016-12-06 5:45 ` [PATCH] xen-scsifront: Add a missing call to kfree Juergen Gross
2016-12-06 10:22 ` Dan Carpenter
2016-11-24 8:24 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205205348.GA31465@mwanda \
--to=dan.carpenter@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jgross@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).