From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752954AbcLEWHb (ORCPT ); Mon, 5 Dec 2016 17:07:31 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:20790 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbcLEWH1 (ORCPT ); Mon, 5 Dec 2016 17:07:27 -0500 Date: Tue, 6 Dec 2016 01:06:47 +0300 From: Dan Carpenter To: "Dilger, Andreas" Cc: James Simmons , "devel@driverdev.osuosl.org" , Greg Kroah-Hartman , Linux Kernel Mailing List , "Drokin, Oleg" , Lustre Development List Subject: Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions Message-ID: <20161205220647.GD8244@mwanda> References: <1480707650-24089-1-git-send-email-jsimmons@infradead.org> <1480707650-24089-4-git-send-email-jsimmons@infradead.org> <20161205205005.GA31243@mwanda> <2394CAB0-41C1-4F3B-AF94-03D302F6ABF5@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2394CAB0-41C1-4F3B-AF94-03D302F6ABF5@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry, I was unclear. I have no problem with white space changes on their own or when they are on the same line as something else you're changing. What I meant is that when you're just moving functions around then don't mix unrelated white space changes into that patch. I have automated scripts for reviewing moving code around but slight changes mean that I have to review it manually line by line to spot the difference. I can review a one liner cleanup in about 10 seconds but it's finding the line which changed that's the problem in this case. And I'm also fine with this patch since I already reviewed it, but in the future, please avoid the temptation to do cleanups until after. regards, dan carpenter