From: Greg KH <gregkh@linuxfoundation.org>
To: kys@microsoft.com
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com,
jasowang@redhat.com, leann.ogasawara@canonical.com
Subject: Re: [PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg()
Date: Tue, 6 Dec 2016 11:07:31 +0100 [thread overview]
Message-ID: <20161206100731.GA32261@kroah.com> (raw)
In-Reply-To: <1480797282-10126-1-git-send-email-kys@exchange.microsoft.com>
On Sat, Dec 03, 2016 at 12:34:28PM -0800, kys@exchange.microsoft.com wrote:
> From: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> DoS protection conditions were altered in WS2016 and now it's easy to get
> -EAGAIN returned from vmbus_post_msg() (e.g. when we try changing MTU on a
> netvsc device in a loop). All vmbus_post_msg() callers don't retry the
> operation and we usually end up with a non-functional device or crash.
>
> While host's DoS protection conditions are unknown to me my tests show that
> it can take up to 10 seconds before the message is sent so doing udelay()
> is not an option, we really need to sleep. Almost all vmbus_post_msg()
> callers are ready to sleep but there is one special case:
> vmbus_initiate_unload() which can be called from interrupt/NMI context and
> we can't sleep there. I'm also not sure about the lonely
> vmbus_send_tl_connect_request() which has no in-tree users but its external
> users are most likely waiting for the host to reply so sleeping there is
> also appropriate.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Shouldn't this go to stable kernels so that 4.9 and earlier can work
properly on WS2016?
thanks,
greg k-h
next prev parent reply other threads:[~2016-12-06 10:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 20:33 [PATCH V2 00/15] Drivers: hv: CPU management fixes and a new uio driver kys
2016-12-03 20:34 ` [PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() kys
2016-12-03 20:34 ` [PATCH V2 02/15] hyperv: Fix spelling of HV_UNKOWN kys
2016-12-03 20:34 ` [PATCH V2 03/15] Drivers: hv: vmbus: Prevent sending data on a rescinded channel kys
2016-12-03 20:34 ` [PATCH V2 04/15] Drivers: hv: vmbus: Enhance the rescind callback functionality kys
2016-12-06 10:08 ` Greg KH
2016-12-03 20:34 ` [PATCH V2 05/15] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() kys
2016-12-03 20:34 ` [PATCH V2 06/15] hv: allocate synic pages for all present CPUs kys
2016-12-06 10:09 ` Greg KH
2016-12-03 20:34 ` [PATCH V2 07/15] hv: init percpu_list in hv_synic_alloc() kys
2016-12-06 10:09 ` Greg KH
2016-12-03 20:34 ` [PATCH V2 08/15] hv: change clockevents unbind tactics kys
2016-12-03 20:34 ` [PATCH V2 09/15] hv: switch to cpuhp state machine for synic init/cleanup kys
2016-12-03 20:34 ` [PATCH V2 10/15] hv: make CPU offlining prevention fine-grained kys
2016-12-03 20:34 ` [PATCH V2 11/15] hv: don't reset hv_context.tsc_page on crash kys
2016-12-03 20:34 ` [PATCH V2 12/15] vmbus: add support for dynamic device id's kys
2016-12-03 20:34 ` [PATCH V2 13/15] uio-hv-generic: new userspace i/o driver for VMBus kys
2016-12-03 20:34 ` [PATCH V2 14/15] Tools: hv: kvp: configurable external scripts path kys
2016-12-03 20:34 ` [PATCH V2 15/15] hyperv: Add a function to detect if the device is a vmbus dev kys
2016-12-06 10:54 ` Greg KH
2016-12-06 14:58 ` KY Srinivasan
2016-12-06 10:07 ` Greg KH [this message]
2016-12-06 10:54 ` [PATCH V2 00/15] Drivers: hv: CPU management fixes and a new uio driver Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206100731.GA32261@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).