From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752547AbcLFKvd (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Dec 2016 05:51:33 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:42828 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752300AbcLFKvb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Dec 2016 05:51:31 -0500
Date: Tue, 6 Dec 2016 11:51:38 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Colin King <colin.king@canonical.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppdev: don't print a free'd string
Message-ID: <20161206105138.GA10275@kroah.com>
References: <20161202162355.25470-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161202162355.25470-1-colin.king@canonical.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 02, 2016 at 04:23:55PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> A previous fix of a memory leak now prints the string 'name'
> that was previously free'd.  Fix this by free'ing the string
> at the end of the function and adding an error exit path for
> the error conditions.
> 
> CoverityScan CID#1384523 ("Use after free")
> 
> Fixes: 2bd362d5f45c1 ("ppdev: fix memory leak")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/char/ppdev.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)

Sudip, any thoughts?