From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbcLFMcb (ORCPT ); Tue, 6 Dec 2016 07:32:31 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33379 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbcLFMc2 (ORCPT ); Tue, 6 Dec 2016 07:32:28 -0500 Date: Tue, 6 Dec 2016 13:32:25 +0100 From: Jiri Pirko To: Feng Deng Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, feng.deng@cortina-access.com Subject: Re: [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan_fill() more robust Message-ID: <20161206123225.GK1984@nanopsycho> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Dec 06, 2016 at 05:46:36AM CET, cxdx2006@gmail.com wrote: >From: Feng Deng > >1.add judgement to make sure switchdev_port_vlan_fill() could > return right, even when switchdev_port_vlan_dump_put() failed , > which will make switchdev_port_vlan_fill() more robust >2.add proper return vlaue at the end of the switchdev_port_vlan_fill() > >Signed-off-by: Feng Deng Please don't send patches like this. You are wasting everyone's time. Thanks!