From: Will Deacon <will.deacon@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Maninder Singh <maninder1.s@samsung.com>,
mark.rutland@arm.com, wangkefeng.wang@huawei.com,
kvm@vger.kernel.org, rkrcmar@redhat.com,
kvmarm@lists.cs.columbia.edu, panand@redhat.com,
cpgs@samsung.com, shijie.huang@arm.com, labbott@redhat.com,
Vaneet Narang <v.narang@samsung.com>,
cmetcalf@mellanox.com, marc.zyngier@arm.com, ajeet.y@samsung.com,
sandeepa.s.prabhu@gmail.com,
linux-arm-kernel@lists.infradead.org, pankaj.m@samsung.com,
ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org,
james.morse@arm.com, pbonzini@redhat.com,
akpm@linux-foundation.org, christoffer.dall@linaro.org
Subject: Re: [PATCH 1/1] arm64: Correcting format specifier for printing 64 bit addresses
Date: Tue, 6 Dec 2016 15:28:38 +0000 [thread overview]
Message-ID: <20161206152837.GM2498@arm.com> (raw)
In-Reply-To: <20161206152637.GC16701@e104818-lin.cambridge.arm.com>
On Tue, Dec 06, 2016 at 03:26:37PM +0000, Catalin Marinas wrote:
> On Mon, Dec 05, 2016 at 11:24:21AM +0000, Will Deacon wrote:
> > On Mon, Dec 05, 2016 at 01:39:53PM +0530, Maninder Singh wrote:
> > > This patch corrects format specifier for printing 64 bit addresses.
> > >
> > > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> > > Signed-off-by: Vaneet Narang <v.narang@samsung.com>
> > > ---
> > > arch/arm64/kernel/signal.c | 2 +-
> > > arch/arm64/kvm/sys_regs.c | 8 ++++++--
> > > arch/arm64/mm/fault.c | 15 ++++++++++-----
> > > arch/arm64/mm/mmu.c | 4 ++--
> > > 4 files changed, 19 insertions(+), 10 deletions(-)
> >
> > Any reason not to fix kvm/trace.h too?
>
> If the KVM guys are ok, I can fold the hunk below into this patch:
>
> diff --git a/arch/arm64/kvm/trace.h b/arch/arm64/kvm/trace.h
> index 7fb0008c4fa3..e117123d414b 100644
> --- a/arch/arm64/kvm/trace.h
> +++ b/arch/arm64/kvm/trace.h
> @@ -20,7 +20,7 @@ TRACE_EVENT(kvm_wfx_arm64,
> __entry->is_wfe = is_wfe;
> ),
>
> - TP_printk("guest executed wf%c at: 0x%08lx",
> + TP_printk("guest executed wf%c at: 0x%016lx",
> __entry->is_wfe ? 'e' : 'i', __entry->vcpu_pc)
> );
>
> @@ -40,7 +40,7 @@ TRACE_EVENT(kvm_hvc_arm64,
> __entry->imm = imm;
> ),
>
> - TP_printk("HVC at 0x%08lx (r0: 0x%08lx, imm: 0x%lx)",
> + TP_printk("HVC at 0x%016lx (r0: 0x%016lx, imm: 0x%lx)",
Not sure we need the 016 prefix for r0.
Will
next prev parent reply other threads:[~2016-12-06 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 8:09 [PATCH 1/1] arm64: Correcting format specifier for printing 64 bit addresses Maninder Singh
2016-12-05 11:24 ` Will Deacon
2016-12-06 15:26 ` Catalin Marinas
2016-12-06 15:28 ` Will Deacon [this message]
2016-12-06 16:11 ` Christoffer Dall
2016-12-06 16:32 ` Robin Murphy
2016-12-14 16:35 ` Paolo Bonzini
2016-12-06 16:43 ` Robin Murphy
-- strict thread matches above, loose matches on Subject: below --
2016-12-05 8:06 Maninder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206152837.GM2498@arm.com \
--to=will.deacon@arm.com \
--cc=ajeet.y@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=cmetcalf@mellanox.com \
--cc=cpgs@samsung.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=panand@redhat.com \
--cc=pankaj.m@samsung.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sandeepa.s.prabhu@gmail.com \
--cc=shijie.huang@arm.com \
--cc=v.narang@samsung.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).