From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yannick Brosseau <scientist@fb.com>
Cc: mingo@redhat.com, peterz@infradead.org, namhyung@kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] perf tools: Explicitly document that --children is enabled by default
Date: Tue, 6 Dec 2016 16:45:42 -0300 [thread overview]
Message-ID: <20161206194542.GD8257@kernel.org> (raw)
In-Reply-To: <20161202160732.29058-1-scientist@fb.com>
Em Fri, Dec 02, 2016 at 11:07:32AM -0500, Yannick Brosseau escreveu:
> The fact that the --children option is enabled by default is buried deep
> at the end of the help page, in the overhead calculation section. This
> make it explicit right where the option is listed, following the same
> way other default options are described
Thanks, applied.
- Arnaldo
> Signed-off-by: Yannick Brosseau <scientist@fb.com>
> ---
> tools/perf/Documentation/perf-report.txt | 3 ++-
> tools/perf/Documentation/perf-top.txt | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> index 2d17462..aaa8011 100644
> --- a/tools/perf/Documentation/perf-report.txt
> +++ b/tools/perf/Documentation/perf-report.txt
> @@ -239,7 +239,8 @@ OPTIONS
> Accumulate callchain of children to parent entry so that then can
> show up in the output. The output will have a new "Children" column
> and will be sorted on the data. It requires callchains are recorded.
> - See the `overhead calculation' section for more details.
> + See the `overhead calculation' section for more details. Enabled by
> + default, disable with --no-children.
>
> --max-stack::
> Set the stack depth limit when parsing the callchain, anything
> diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
> index 91d638d..e71d638 100644
> --- a/tools/perf/Documentation/perf-top.txt
> +++ b/tools/perf/Documentation/perf-top.txt
> @@ -170,6 +170,7 @@ Default is to monitor all CPUS.
> show up in the output. The output will have a new "Children" column
> and will be sorted on the data. It requires -g/--call-graph option
> enabled. See the `overhead calculation' section for more details.
> + Enabled by default, disable with --no-children.
>
> --max-stack::
> Set the stack depth limit when parsing the callchain, anything
> --
> 2.10.2
next prev parent reply other threads:[~2016-12-06 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 16:07 [PATCH] perf tools: Explicitly document that --children is enabled by default Yannick Brosseau
2016-12-06 19:45 ` Arnaldo Carvalho de Melo [this message]
2016-12-07 18:26 ` [tip:perf/core] " tip-bot for Yannick Brosseau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206194542.GD8257@kernel.org \
--to=acme@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=scientist@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox