public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf tools: Explicitly document that --children is enabled by default
@ 2016-12-02 16:07 Yannick Brosseau
  2016-12-06 19:45 ` Arnaldo Carvalho de Melo
  2016-12-07 18:26 ` [tip:perf/core] " tip-bot for Yannick Brosseau
  0 siblings, 2 replies; 3+ messages in thread
From: Yannick Brosseau @ 2016-12-02 16:07 UTC (permalink / raw)
  To: acme; +Cc: mingo, peterz, namhyung, linux-kernel, kernel-team,
	Yannick Brosseau

The fact that the --children option is enabled by default is buried deep
at the end of the help page, in the overhead calculation section. This
make it explicit right where the option is listed, following the same
way other default options are described

Signed-off-by: Yannick Brosseau <scientist@fb.com>
---
 tools/perf/Documentation/perf-report.txt | 3 ++-
 tools/perf/Documentation/perf-top.txt    | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index 2d17462..aaa8011 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -239,7 +239,8 @@ OPTIONS
 	Accumulate callchain of children to parent entry so that then can
 	show up in the output.  The output will have a new "Children" column
 	and will be sorted on the data.  It requires callchains are recorded.
-	See the `overhead calculation' section for more details.
+	See the `overhead calculation' section for more details. Enabled by
+	default, disable with --no-children.
 
 --max-stack::
 	Set the stack depth limit when parsing the callchain, anything
diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
index 91d638d..e71d638 100644
--- a/tools/perf/Documentation/perf-top.txt
+++ b/tools/perf/Documentation/perf-top.txt
@@ -170,6 +170,7 @@ Default is to monitor all CPUS.
 	show up in the output.  The output will have a new "Children" column
 	and will be sorted on the data.  It requires -g/--call-graph option
 	enabled.  See the `overhead calculation' section for more details.
+	Enabled by default, disable with --no-children.
 
 --max-stack::
 	Set the stack depth limit when parsing the callchain, anything
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf tools: Explicitly document that --children is enabled by default
  2016-12-02 16:07 [PATCH] perf tools: Explicitly document that --children is enabled by default Yannick Brosseau
@ 2016-12-06 19:45 ` Arnaldo Carvalho de Melo
  2016-12-07 18:26 ` [tip:perf/core] " tip-bot for Yannick Brosseau
  1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-12-06 19:45 UTC (permalink / raw)
  To: Yannick Brosseau; +Cc: mingo, peterz, namhyung, linux-kernel, kernel-team

Em Fri, Dec 02, 2016 at 11:07:32AM -0500, Yannick Brosseau escreveu:
> The fact that the --children option is enabled by default is buried deep
> at the end of the help page, in the overhead calculation section. This
> make it explicit right where the option is listed, following the same
> way other default options are described

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Yannick Brosseau <scientist@fb.com>
> ---
>  tools/perf/Documentation/perf-report.txt | 3 ++-
>  tools/perf/Documentation/perf-top.txt    | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> index 2d17462..aaa8011 100644
> --- a/tools/perf/Documentation/perf-report.txt
> +++ b/tools/perf/Documentation/perf-report.txt
> @@ -239,7 +239,8 @@ OPTIONS
>  	Accumulate callchain of children to parent entry so that then can
>  	show up in the output.  The output will have a new "Children" column
>  	and will be sorted on the data.  It requires callchains are recorded.
> -	See the `overhead calculation' section for more details.
> +	See the `overhead calculation' section for more details. Enabled by
> +	default, disable with --no-children.
>  
>  --max-stack::
>  	Set the stack depth limit when parsing the callchain, anything
> diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
> index 91d638d..e71d638 100644
> --- a/tools/perf/Documentation/perf-top.txt
> +++ b/tools/perf/Documentation/perf-top.txt
> @@ -170,6 +170,7 @@ Default is to monitor all CPUS.
>  	show up in the output.  The output will have a new "Children" column
>  	and will be sorted on the data.  It requires -g/--call-graph option
>  	enabled.  See the `overhead calculation' section for more details.
> +	Enabled by default, disable with --no-children.
>  
>  --max-stack::
>  	Set the stack depth limit when parsing the callchain, anything
> -- 
> 2.10.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:perf/core] perf tools: Explicitly document that --children is enabled by default
  2016-12-02 16:07 [PATCH] perf tools: Explicitly document that --children is enabled by default Yannick Brosseau
  2016-12-06 19:45 ` Arnaldo Carvalho de Melo
@ 2016-12-07 18:26 ` tip-bot for Yannick Brosseau
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Yannick Brosseau @ 2016-12-07 18:26 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: hpa, linux-kernel, namhyung, mingo, peterz, tglx, acme, scientist

Commit-ID:  108a7c103b761309ccbd997002e8428808cf1e04
Gitweb:     http://git.kernel.org/tip/108a7c103b761309ccbd997002e8428808cf1e04
Author:     Yannick Brosseau <scientist@fb.com>
AuthorDate: Fri, 2 Dec 2016 11:07:32 -0500
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 7 Dec 2016 12:00:35 -0300

perf tools: Explicitly document that --children is enabled by default

The fact that the --children option is enabled by default is buried deep
at the end of the help page, in the overhead calculation section. This
make it explicit right where the option is listed, following the same
way other default options are described

Signed-off-by: Yannick Brosseau <scientist@fb.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: kernel-team@fb.com
Link: http://lkml.kernel.org/r/20161202160732.29058-1-scientist@fb.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-report.txt | 3 ++-
 tools/perf/Documentation/perf-top.txt    | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index 3a166ae..f2914f0 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -239,7 +239,8 @@ OPTIONS
 	Accumulate callchain of children to parent entry so that then can
 	show up in the output.  The output will have a new "Children" column
 	and will be sorted on the data.  It requires callchains are recorded.
-	See the `overhead calculation' section for more details.
+	See the `overhead calculation' section for more details. Enabled by
+	default, disable with --no-children.
 
 --max-stack::
 	Set the stack depth limit when parsing the callchain, anything
diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
index 91d638d..e71d638 100644
--- a/tools/perf/Documentation/perf-top.txt
+++ b/tools/perf/Documentation/perf-top.txt
@@ -170,6 +170,7 @@ Default is to monitor all CPUS.
 	show up in the output.  The output will have a new "Children" column
 	and will be sorted on the data.  It requires -g/--call-graph option
 	enabled.  See the `overhead calculation' section for more details.
+	Enabled by default, disable with --no-children.
 
 --max-stack::
 	Set the stack depth limit when parsing the callchain, anything

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-12-07 18:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-02 16:07 [PATCH] perf tools: Explicitly document that --children is enabled by default Yannick Brosseau
2016-12-06 19:45 ` Arnaldo Carvalho de Melo
2016-12-07 18:26 ` [tip:perf/core] " tip-bot for Yannick Brosseau

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox