From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbcLFXqN (ORCPT ); Tue, 6 Dec 2016 18:46:13 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35832 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbcLFXqG (ORCPT ); Tue, 6 Dec 2016 18:46:06 -0500 From: Marcos Paulo de Souza Cc: Marcos Paulo de Souza , Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] Input: i8042 - Add warn when a command can't write its parameter Date: Tue, 6 Dec 2016 21:44:54 -0200 Message-Id: <20161206234531.4320-1-marcos.souza.org@gmail.com> X-Mailer: git-send-email 2.9.3 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This can happen in cases like bug #102951[1], so add a proper warn as done in wait_read. [1] https://bugzilla.kernel.org/show_bug.cgi?id=102951 Signed-off-by: Marcos Paulo de Souza --- drivers/input/serio/i8042.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 89abfdb..1c70747 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -312,8 +312,10 @@ static int __i8042_command(unsigned char *param, int command) for (i = 0; i < ((command >> 12) & 0xf); i++) { error = i8042_wait_write(); - if (error) + if (error) { + pr_warn("Can't write i8042 parameter, wait_write timed out\n"); return error; + } dbg("%02x -> i8042 (parameter)\n", param[i]); i8042_write_data(param[i]); } -- 2.9.3