From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753113AbcLGNkh (ORCPT ); Wed, 7 Dec 2016 08:40:37 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36010 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752918AbcLGNkg (ORCPT ); Wed, 7 Dec 2016 08:40:36 -0500 Date: Wed, 7 Dec 2016 14:40:33 +0100 From: Pavel Machek To: Thomas Gleixner Cc: Len Brown , x86@kernel.org, linux-kernel@vger.kernel.org, Len Brown Subject: Re: [PATCH 2/5] x86: remove idle_notifier Message-ID: <20161207134033.GA22493@amd> References: <20161206165420.GA4406@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2016-12-07 12:46:12, Thomas Gleixner wrote: > On Tue, 6 Dec 2016, Pavel Machek wrote: > > > From: Len Brown > > >=20 > > > Upon removal of the i7300_idle driver, the idle_notifer is unused. > >=20 > > Actually... do we want to keep this this one? There's "cpu is loaded" > > led trigger, which is implemented on arm but not on x86. > >=20 > > I tried to patch process.c, but this would be easier (and does not > > require new hooks). > >=20 > > Does that make sense? >=20 > No. Notifiers are crap. >=20 > I assume this LED thing is just for entertainment purposes as I cannot > figure out why it would be useful. ARM has it does not qualify as useful. Well, on low-speed systems, that led is actually quite important. You know if your keypress was registered, and CPU is just slow, or if you need to press it again. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlhIEVEACgkQMOfwapXb+vKblwCfSeKvD0i47GWe7+9NHc6ohzFx 0OMAn0B4LVEgpTu1yqQOtyjaUjTrRUcY =8MAb -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt--