From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Nick Dyer <nick@shmanahar.org>
Cc: Andrew Duggan <aduggan@synaptics.com>,
Chris Healy <cphealy@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip
Date: Wed, 7 Dec 2016 17:22:18 -0800 [thread overview]
Message-ID: <20161208012218.GA27638@dtor-ws> (raw)
In-Reply-To: <1480899881-31425-1-git-send-email-nick@shmanahar.org>
On Mon, Dec 05, 2016 at 01:04:41AM +0000, Nick Dyer wrote:
> The debug would only ever output zero for the clip information.
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
Applied, thank you.
> ---
>
> drivers/input/rmi4/rmi_f12.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
> index 8c5360c..e35c64b 100644
> --- a/drivers/input/rmi4/rmi_f12.c
> +++ b/drivers/input/rmi4/rmi_f12.c
> @@ -71,10 +71,6 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
> u8 buf[15];
> int pitch_x = 0;
> int pitch_y = 0;
> - int clip_x_low = 0;
> - int clip_x_high = 0;
> - int clip_y_low = 0;
> - int clip_y_high = 0;
> int rx_receivers = 0;
> int tx_receivers = 0;
> int sensor_flags = 0;
> @@ -127,7 +123,8 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
> }
>
> rmi_dbg(RMI_DEBUG_FN, &fn->dev, "%s: x low: %d x high: %d y low: %d y high: %d\n",
> - __func__, clip_x_low, clip_x_high, clip_y_low, clip_y_high);
> + __func__, sensor->axis_align.clip_x_low, sensor->axis_align.clip_x_high,
> + sensor->axis_align.clip_y_low, sensor->axis_align.clip_y_high);
>
> if (rmi_register_desc_has_subpacket(item, 3)) {
> rx_receivers = buf[offset];
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2016-12-08 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 1:04 [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip Nick Dyer
2016-12-05 18:04 ` Andrew Duggan
2016-12-08 1:22 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208012218.GA27638@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=cphealy@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).