From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752987AbcLHNaV (ORCPT ); Thu, 8 Dec 2016 08:30:21 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47632 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751792AbcLHNaU (ORCPT ); Thu, 8 Dec 2016 08:30:20 -0500 Date: Thu, 8 Dec 2016 14:30:19 +0100 From: Greg Kroah-Hartman To: SF Markus Elfring Cc: devel@driverdev.osuosl.org, Chris Cesare , H Hartley Sweeten , Ian Abbott , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/5] staging-COMEDI: Fine-tuning for three functions Message-ID: <20161208133019.GA30859@kroah.com> References: <8cddc37d-4529-ada4-ac21-20e09e888d0d@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8cddc37d-4529-ada4-ac21-20e09e888d0d@users.sourceforge.net> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 08, 2016 at 12:30:20PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 8 Dec 2016 11:37:37 +0100 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): > Combine four kcalloc() calls into one in serial2002_setup_subdevs() > Split a condition check in usbdux_alloc_usb_buffers() > Move an assignment in usbdux_alloc_usb_buffers() > Split a condition check in usbduxsigma_alloc_usb_buffers() > Move an assignment in usbduxsigma_alloc_usb_buffers() > > drivers/staging/comedi/drivers/serial2002.c | 22 +++++----- > drivers/staging/comedi/drivers/usbdux.c | 56 ++++++++++++++++++----- > drivers/staging/comedi/drivers/usbduxsigma.c | 66 ++++++++++++++++++++++------ > 3 files changed, 108 insertions(+), 36 deletions(-) You do realize that I no longer take patches from you for any of the subsystems I maintain, right? This patch series is one reason why... I suggest working on other projects to learn C better first. best of luck, greg k-h