From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937AbcLHO0c (ORCPT ); Thu, 8 Dec 2016 09:26:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41878 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752635AbcLHO0a (ORCPT ); Thu, 8 Dec 2016 09:26:30 -0500 Date: Thu, 8 Dec 2016 16:25:55 +0200 From: "Michael S. Tsirkin" To: Jason Wang Cc: linux-kernel@vger.kernel.org, Stefan Hajnoczi , "David S. Miller" , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH 08/10] vsock/virtio: mark an internal function static Message-ID: <20161208162458-mutt-send-email-mst@kernel.org> References: <1481038106-24899-1-git-send-email-mst@redhat.com> <1481038106-24899-9-git-send-email-mst@redhat.com> <487d3d4a-7a53-cb45-2cfd-5eb68d9b73f0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <487d3d4a-7a53-cb45-2cfd-5eb68d9b73f0@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 08 Dec 2016 14:26:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 07, 2016 at 12:21:22PM +0800, Jason Wang wrote: > > > On 2016年12月06日 23:41, Michael S. Tsirkin wrote: > > virtio_transport_alloc_pkt is only used locally, make it static. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > net/vmw_vsock/virtio_transport_common.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > > index a53b3a1..6120384 100644 > > --- a/net/vmw_vsock/virtio_transport_common.c > > +++ b/net/vmw_vsock/virtio_transport_common.c > > @@ -32,7 +32,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void) > > return container_of(t, struct virtio_transport, transport); > > } > > -struct virtio_vsock_pkt * > > +static struct virtio_vsock_pkt * > > virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info, > > size_t len, > > u32 src_cid, > > Git grep shows it was used by tracing. True but trace_virtio_transport_alloc_pkt is also local to virtio_transport_common.c -- MST