From: Greg KH <gregkh@linuxfoundation.org>
To: Manoj Sawai <mas@iitkgp.ac.in>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: ks7010: ks7010_sdio.h: Fixed coding style errors
Date: Fri, 9 Dec 2016 08:02:34 +0100 [thread overview]
Message-ID: <20161209070234.GA13178@kroah.com> (raw)
In-Reply-To: <20161209122921.6147-1-mas@iitkgp.ac.in>
On Fri, Dec 09, 2016 at 12:29:21PM +0000, Manoj Sawai wrote:
> Errors - Complex macro not a parentheses and trailing whitespace
> Also fixed other small checkpatch warnings and checks.
If you ever say "also" in a changelog, that's a huge hint that the patch
needs to be broken up into multiple patches. That is the case here,
please only do one type of coding style fix at a time.
thanks,
greg k-h
prev parent reply other threads:[~2016-12-09 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 12:29 [PATCH] Staging: ks7010: ks7010_sdio.h: Fixed coding style errors Manoj Sawai
2016-12-09 7:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209070234.GA13178@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mas@iitkgp.ac.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox