From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754082AbcLIPau (ORCPT ); Fri, 9 Dec 2016 10:30:50 -0500 Received: from mx2.suse.de ([195.135.220.15]:48934 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753889AbcLIPat (ORCPT ); Fri, 9 Dec 2016 10:30:49 -0500 Date: Fri, 9 Dec 2016 16:30:37 +0100 From: Jean Delvare To: Kefeng Wang Cc: Ard Biesheuvel , Mark Rutland , Subject: Re: [PATCH] firmware: dmi_scan: Always show system identification string Message-ID: <20161209163037.5b27099b@endymion> In-Reply-To: <1481266447-51471-1-git-send-email-wangkefeng.wang@huawei.com> References: <1481266447-51471-1-git-send-email-wangkefeng.wang@huawei.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wang, On Fri, 9 Dec 2016 14:54:07 +0800, Kefeng Wang wrote: > Let's keep consistent when print dmi_ids_string between SMBIOS 2.x > and SMBIOS 3.x, and always show the system identification string, > like Vendor, Product/Board name and BIOS infos. > > Signed-off-by: Kefeng Wang > --- > drivers/firmware/dmi_scan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c > index 88bebe1..54be60e 100644 > --- a/drivers/firmware/dmi_scan.c > +++ b/drivers/firmware/dmi_scan.c > @@ -560,7 +560,7 @@ static int __init dmi_present(const u8 *buf) > dmi_ver >> 16, (dmi_ver >> 8) & 0xFF); > } > dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string)); > - printk(KERN_DEBUG "DMI: %s\n", dmi_ids_string); > + pr_info("DMI: %s\n", dmi_ids_string); > return 0; > } > } > @@ -588,7 +588,7 @@ static int __init dmi_smbios3_present(const u8 *buf) > dmi_ver >> 16, (dmi_ver >> 8) & 0xFF, > dmi_ver & 0xFF); > dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string)); > - pr_debug("DMI: %s\n", dmi_ids_string); > + pr_info("DMI: %s\n", dmi_ids_string); > return 0; > } > } I agree. Applied, thanks. -- Jean Delvare SUSE L3 Support