From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752480AbcLITXQ (ORCPT ); Fri, 9 Dec 2016 14:23:16 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34145 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcLITXP (ORCPT ); Fri, 9 Dec 2016 14:23:15 -0500 Date: Fri, 9 Dec 2016 11:23:10 -0800 From: Bjorn Andersson To: Arnd Bergmann Cc: Ohad Ben-Cohen , Srinivas Kandagatla , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: qcom_adsp_pil: select qcom_scm Message-ID: <20161209192310.GY30492@tuxbot> References: <20161209114730.3780719-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161209114730.3780719-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 09 Dec 03:47 PST 2016, Arnd Bergmann wrote: > The adsp-pil driver relies on SCM and causes a build error without it: > > ERROR: "qcom_scm_pas_supported" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > ERROR: "qcom_scm_is_available" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > ERROR: "qcom_scm_pas_auth_and_reset" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > ERROR: "qcom_scm_pas_shutdown" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > ERROR: "qcom_scm_pas_mem_setup" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > ERROR: "qcom_scm_pas_init_image" [drivers/remoteproc/qcom_adsp_pil.ko] undefined! > > This adds a 'select', as SCM is a silent Kconfig symbol that gets > enabled implicitly by all its users. > Thanks, sorry for giving you the opportunity for finding all these odd combinations. Are you aware of any projects aiming to catch these through e.g. dependency analysis rather than random build testing (and my now growing manual checklist)? Regards, Bjorn > Fixes: b9e718e950c3 ("remoteproc: Introduce Qualcomm ADSP PIL") > Signed-off-by: Arnd Bergmann > --- > drivers/remoteproc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig > index 51d7ca0e10fc..1177329b7618 100644 > --- a/drivers/remoteproc/Kconfig > +++ b/drivers/remoteproc/Kconfig > @@ -85,6 +85,7 @@ config QCOM_ADSP_PIL > depends on QCOM_SMEM > select MFD_SYSCON > select QCOM_MDT_LOADER > + select QCOM_SCM > help > Say y here to support the TrustZone based Peripherial Image Loader > for the Qualcomm ADSP remote processors. > -- > 2.9.0 >