From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbcLIXyw (ORCPT ); Fri, 9 Dec 2016 18:54:52 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:33828 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648AbcLIXyu (ORCPT ); Fri, 9 Dec 2016 18:54:50 -0500 Date: Fri, 9 Dec 2016 21:54:33 -0200 From: Marcos Paulo de Souza To: Dmitry Torokhov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Takashi Iwai Subject: Re: [PATCH 0/4] x86: Trust firmware a bit more about presence of 8042 Message-ID: <20161209235432.GA9185@xfiles> References: <1481317061-31486-1-git-send-email-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481317061-31486-1-git-send-email-dmitry.torokhov@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Fri, Dec 09, 2016 at 12:57:37PM -0800, Dmitry Torokhov wrote: > Hi, > > Historically we did not trust PNP data regarding keyboard controllers on > X86, but more and more boards get upset with us if they try to tell us that > there is no keyboard controller and we still go and try to poke at where we > think it might be. To work around this issue let's have a bit more faith in > BIOS data, and if [lack] of PNP devices for mouse and keyboard matches whet > firmware (basically ACPI FADT) tells us, let's abort i8042 probe. > > We add a new flag (enum) to x86_platform.legacy structure so we can > distinguish between cases where platform/subarch never has 8042 (such as > MID platform) and cases where firmware says that it is not there, so that > i8042 driver can either abort immediately or go and check for presence of > PNP devices. We also remove x86_platform.i8042_detect() as it is no longer > used (platforms can set value of x86_platform.legacy.i8042 as needed in > quirks). > > If you are OK with arch/x86 changes please apply together with the input > part. Looks very good, better than my initial idea of adding more code into i8042_detect. Acked-by: Marcos Paulo de Souza > > Thanks, > Dmitry > > Dmitry Torokhov (4): > x86/init: add i8042 state to the platform data > Input: i8042 - trust firmware a bit more when probing on X86 > x86/init: remove i8042_detect() form platform ops > x86/init: fix a couple typos in arch/x86/include/asm/x86_init.h > > arch/x86/include/asm/x86_init.h | 26 +++++++++++++++++++++----- > arch/x86/kernel/acpi/boot.c | 7 +++++++ > arch/x86/kernel/platform-quirks.c | 5 +++++ > arch/x86/kernel/x86_init.c | 2 -- > arch/x86/platform/ce4100/ce4100.c | 6 ------ > arch/x86/platform/intel-mid/intel-mid.c | 7 ------- > drivers/input/serio/i8042-x86ia64io.h | 10 +++++++--- > 7 files changed, 40 insertions(+), 23 deletions(-) > > -- > 2.8.0.rc3.226.g39d4020 >