From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Simmons <jsimmons@infradead.org>
Cc: devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>,
James Simmons <uja.ornl@yahoo.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h
Date: Sat, 10 Dec 2016 19:16:49 +0100 [thread overview]
Message-ID: <20161210181649.GB8477@kroah.com> (raw)
In-Reply-To: <1481393161-22623-6-git-send-email-jsimmons@infradead.org>
On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote:
> In order for lustre_idl.h to be usable for both user
> land and kernel space it has to use the proper
> byteorder functions.
Why would userspace need/want all of these inline functions? A uapi
header file should just have a the structures that are passed
user/kernel and any needed ioctls. Why would they ever care about
strange byte flip functions and a ton of inline functions?
I don't think this is needed, of if it is, I really don't want to see
your crazy userspace code...
thanks,
greg k-h
next prev parent reply other threads:[~2016-12-10 18:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 18:05 [PATCH v2 0/5] Fix ups to make lustre_idl.h a proper UAPI header James Simmons
2016-12-10 18:05 ` [PATCH v2 1/5] staging: lustre: obdclass: Create a header for obdo related functions James Simmons
2016-12-10 18:05 ` [PATCH v2 2/5] staging: lustre: obdclass: style cleanup " James Simmons
2016-12-10 18:05 ` [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move James Simmons
2016-12-10 18:14 ` Greg Kroah-Hartman
2016-12-12 14:42 ` Ben Evans
2016-12-12 16:34 ` Greg Kroah-Hartman
2016-12-12 18:12 ` Ben Evans
2016-12-12 18:19 ` Joe Perches
2016-12-12 19:41 ` James Simmons
2016-12-12 19:52 ` Joe Perches
2016-12-10 18:06 ` [PATCH v2 4/5] staging: lustre: headers: Move functions out of lustre_idl.h James Simmons
2016-12-10 18:06 ` [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h James Simmons
2016-12-10 18:16 ` Greg Kroah-Hartman [this message]
2016-12-12 20:00 ` James Simmons
2016-12-13 0:37 ` Greg Kroah-Hartman
2016-12-13 8:31 ` Dan Carpenter
2016-12-13 16:14 ` Oleg Drokin
2016-12-13 17:21 ` Dan Carpenter
2016-12-13 0:55 ` Dilger, Andreas
2016-12-13 1:07 ` Greg Kroah-Hartman
2016-12-19 17:02 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161210181649.GB8477@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
--cc=uja.ornl@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox