From: "acme@kernel.org" <acme@kernel.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"andi@firstfloor.org" <andi@firstfloor.org>
Subject: Re: [PATCH] perf tools: ignore zombie process for user profile
Date: Wed, 14 Dec 2016 16:13:20 -0300 [thread overview]
Message-ID: <20161214191320.GA6866@kernel.org> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0775367F8F6@SHSMSX103.ccr.corp.intel.com>
Em Wed, Dec 14, 2016 at 06:26:02PM +0000, Liang, Kan escreveu:
> > On Wed, Dec 14, 2016 at 12:48:05PM -0500, kan.liang@intel.com wrote:
> > > From: Kan Liang <kan.liang@intel.com>
> > > Zombie process is dead process. It is meaningless to profile it.
> > > It's better to ignore it for user profile.
> > I recently posted different patch for same issue:
> > http://marc.info/?l=linux-kernel&m=148153895827359&w=2
> The change as below make me confuse.
> + /* The system wide setup does not work with threads. */
> + if (!evsel->system_wide)
> + return false;
> It looks the meaning of the comments is inconsistent with the code.
> Your original patch doesn't work well with the issue.
> But if I change the above code as below, the issue is fixed.
> if (evsel->system_wide)
> return false;
yeah, Namhyung noticed that, Jiri sent a fixed patch, I have it already
in my perf/core branch.
- Arnaldo
next prev parent reply other threads:[~2016-12-14 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 17:48 [PATCH] perf tools: ignore zombie process for user profile kan.liang
2016-12-14 17:59 ` Jiri Olsa
2016-12-14 18:26 ` Liang, Kan
2016-12-14 19:13 ` acme [this message]
2016-12-14 19:19 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214191320.GA6866@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox