From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935063AbcLOBi0 (ORCPT ); Wed, 14 Dec 2016 20:38:26 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47932 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbcLOBiZ (ORCPT ); Wed, 14 Dec 2016 20:38:25 -0500 Date: Wed, 14 Dec 2016 17:38:34 -0800 From: Greg KH To: Tabrez khan Cc: andreas.dilger@intel.com, jsimmons@infradead.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging : osc : Remove braces from single-line body Message-ID: <20161215013834.GA7055@kroah.com> References: <1481765632-29876-1-git-send-email-khan.tabrez21@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481765632-29876-1-git-send-email-khan.tabrez21@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2016 at 07:03:52AM +0530, Tabrez khan wrote: > Remove unnecessary braces {} for single if statement block. > This warning is found using checkpatch.pl. > > Signed-off-by: Tabrez khan > --- > drivers/staging/lustre/lustre/osc/osc_cache.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c b/drivers/staging/lustre/lustre/osc/osc_cache.c > index 4bbe219..5ded31a 100644 > --- a/drivers/staging/lustre/lustre/osc/osc_cache.c > +++ b/drivers/staging/lustre/lustre/osc/osc_cache.c > @@ -1420,10 +1420,8 @@ static void osc_release_write_grant(struct client_obd *cli, > struct brw_page *pga) > { > assert_spin_locked(&cli->cl_loi_list_lock); > - if (!(pga->flag & OBD_BRW_FROM_GRANT)) { > + if (!(pga->flag & OBD_BRW_FROM_GRANT)) > return; > - } > - Why did you also delete the blank line?