From: Greg KH <gregkh@linuxfoundation.org>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: arnd@arndb.de, samuel@sortiz.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h
Date: Thu, 15 Dec 2016 03:54:06 -0800 [thread overview]
Message-ID: <20161215115406.GA22905@kroah.com> (raw)
In-Reply-To: <20161215104250.16813-3-clabbe.montjoie@gmail.com>
On Thu, Dec 15, 2016 at 11:42:48AM +0100, Corentin Labbe wrote:
> This patch move the define for IRNET_MINOR to include/linux/miscdevice.h
> It is better that all minor number definitions are in the same place.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> include/linux/miscdevice.h | 1 +
> net/irda/irnet/irnet_ppp.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
> index 18b2e3b..5ea0a65 100644
> --- a/include/linux/miscdevice.h
> +++ b/include/linux/miscdevice.h
> @@ -37,6 +37,7 @@
> #define HWRNG_MINOR 183
> #define MICROCODE_MINOR 184
> #define KEYPAD_MINOR 185
> +#define IRNET_MINOR 187
> #define D7S_MINOR 193
> #define VFIO_MINOR 196
> #define TUN_MINOR 200
> diff --git a/net/irda/irnet/irnet_ppp.h b/net/irda/irnet/irnet_ppp.h
> index 693ebc0..18fcead 100644
> --- a/net/irda/irnet/irnet_ppp.h
> +++ b/net/irda/irnet/irnet_ppp.h
> @@ -21,7 +21,6 @@
>
> /* /dev/irnet file constants */
> #define IRNET_MAJOR 10 /* Misc range */
> -#define IRNET_MINOR 187 /* Official allocation */
>
> /* IrNET control channel stuff */
> #define IRNET_MAX_COMMAND 256 /* Max length of a command line */
> --
> 2.10.2
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2016-12-15 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 10:42 [PATCH 1/5] irda: irproc.c: Remove unneeded linux/miscdevice.h include Corentin Labbe
2016-12-15 10:42 ` [PATCH 2/5] irda: irnet: Move " Corentin Labbe
2016-12-17 16:18 ` David Miller
2016-12-15 10:42 ` [PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h Corentin Labbe
2016-12-15 11:54 ` Greg KH [this message]
2016-12-17 16:18 ` David Miller
2016-12-15 10:42 ` [PATCH 4/5] irda: irnet: Remove unused IRNET_MAJOR define Corentin Labbe
2016-12-17 16:18 ` David Miller
2016-12-15 10:42 ` [PATCH 5/5] irda: irnet: add member name to the miscdevice declaration Corentin Labbe
2016-12-17 16:18 ` David Miller
2016-12-17 16:18 ` [PATCH 1/5] irda: irproc.c: Remove unneeded linux/miscdevice.h include David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215115406.GA22905@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox