From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933789AbcLPI4C (ORCPT ); Fri, 16 Dec 2016 03:56:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:33281 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757181AbcLPIz5 (ORCPT ); Fri, 16 Dec 2016 03:55:57 -0500 Date: Fri, 16 Dec 2016 09:55:50 +0100 From: Johannes Thumshirn To: Arnd Bergmann Cc: Yuval Mintz , Ariel Elior , everest-linux-l2@cavium.com, Arun Easi , Hannes Reinecke , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] qed: fix old-style function definition Message-ID: <20161216085550.GA3840@linux-x5ow.site> References: <20161216084808.1815139-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161216084808.1815139-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 09:47:41AM +0100, Arnd Bergmann wrote: > The newly added file causes a harmless warning, with "make W=1": > > drivers/net/ethernet/qlogic/qed/qed_iscsi.c: In function 'qed_get_iscsi_ops': > drivers/net/ethernet/qlogic/qed/qed_iscsi.c:1268:29: warning: old-style function definition [-Wold-style-definition] > > This makes it a proper prototype. > > Fixes: fc831825f99e ("qed: Add support for hardware offloaded iSCSI.") > Signed-off-by: Arnd Bergmann > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850