From: Christoph Hellwig <hch@infradead.org>
To: Richard Weinberger <richard@nod.at>
Cc: Arnd Bergmann <arnd@arndb.de>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Eric Biggers <ebiggers@google.com>,
David Gstir <david@sigma-star.at>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption
Date: Fri, 16 Dec 2016 01:35:45 -0800 [thread overview]
Message-ID: <20161216093545.GA8352@infradead.org> (raw)
In-Reply-To: <1df9c2e6-fdf8-404d-4678-7b45958f07f3@nod.at>
On Fri, Dec 16, 2016 at 10:26:35AM +0100, Richard Weinberger wrote:
> > The easiest way out is to limit UBIFS_FS_ENCRYPTION to configurations
> > that also enable BLOCK.
>
> Thanks for the fix!
> I'll queue this for -rc2.
>
> In the long-run I'd like to remove the CONFIG_BLOCK dependency from fs/crypto/crypto.c
> since UBIFS does not use the block related functions at all.
I would much prefer if you did that fixup now. Either by moving
all the block code into a new fs/crypto/bio.c or if that's too hard
by just sprinkling ifdefs.
prev parent reply other threads:[~2016-12-16 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 8:42 [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption Arnd Bergmann
2016-12-16 9:26 ` Richard Weinberger
2016-12-16 9:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216093545.GA8352@infradead.org \
--to=hch@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=david@sigma-star.at \
--cc=dedekind1@gmail.com \
--cc=ebiggers@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).