From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759929AbcLPJfy (ORCPT ); Fri, 16 Dec 2016 04:35:54 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:38020 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754798AbcLPJft (ORCPT ); Fri, 16 Dec 2016 04:35:49 -0500 Date: Fri, 16 Dec 2016 01:35:45 -0800 From: Christoph Hellwig To: Richard Weinberger Cc: Arnd Bergmann , Artem Bityutskiy , Adrian Hunter , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Ext4 Developers List , "Theodore Ts'o" , Eric Biggers , David Gstir , Randy Dunlap Subject: Re: [PATCH] ubifs: add CONFIG_BLOCK dependency for encryption Message-ID: <20161216093545.GA8352@infradead.org> References: <20161216084231.1637761-1-arnd@arndb.de> <1df9c2e6-fdf8-404d-4678-7b45958f07f3@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1df9c2e6-fdf8-404d-4678-7b45958f07f3@nod.at> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 10:26:35AM +0100, Richard Weinberger wrote: > > The easiest way out is to limit UBIFS_FS_ENCRYPTION to configurations > > that also enable BLOCK. > > Thanks for the fix! > I'll queue this for -rc2. > > In the long-run I'd like to remove the CONFIG_BLOCK dependency from fs/crypto/crypto.c > since UBIFS does not use the block related functions at all. I would much prefer if you did that fixup now. Either by moving all the block code into a new fs/crypto/bio.c or if that's too hard by just sprinkling ifdefs.