From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760873AbcLPLOM (ORCPT ); Fri, 16 Dec 2016 06:14:12 -0500 Received: from mail1.bemta3.messagelabs.com ([195.245.230.167]:40824 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757358AbcLPLNw (ORCPT ); Fri, 16 Dec 2016 06:13:52 -0500 X-Greylist: delayed 515 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Dec 2016 06:13:52 EST X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRWlGSWpSXmKPExsUSt3OpsW78qeA Ig88LDC2uXDzEZDH14RM2i29XOpgsLu+aw2bRuauf1WLD97WMDmweGz43sXnsnHWX3WPTqk42 j31vl7F5rN9ylcXj8ya5ALYo1sy8pPyKBNaMI42yBZM4K57+F25gfMLexcjFISSwnlGia/lM1 i5GTiCnQmLW3i3sIDabgIXE5BMP2EBsFgFVicUztgHFOTiEBQIlNhxmA+kVEehilFj96jFYPb NAucSWTxOZQWxeAQeJ6duusULYghInZz5hgaiRkDj44gUzxC4DidMLGsHiEgL2EtPfX2UGmS8 hoC/ReCwWImwo8X3WN6gSc4nuBZeYJzDyz0IydRaSqQsYmVYxqhenFpWlFuma6iUVZaZnlOQm ZuboGhoY6+WmFhcnpqfmJCYV6yXn525iBAZyPQMD4w7Gy1+dDjFKcjApifIu3xEcIcSXlJ9Sm ZFYnBFfVJqTWnyIUYaDQ0mCV/MkUE6wKDU9tSItMwcYUzBpCQ4eJRFeX5A0b3FBYm5xZjpE6h SjopQ479cTQAkBkERGaR5cGyyOLzHKSgnzMjIwMAjxFKQW5WaWoMq/YhTnYFQS5n0LMoUnM68 EbvoroMVMQIst5oEtLklESEk1MD5Y1PF6Y4zTpOm5DTXGC2R3PQxdOP39LWs3MyO5sNKI7783 GZxavMiswyjv7vll9rOyl2R1qxpMkUoqXy195daD06c2Lj812+C+Wyxj/o6wurk3TrNrzVZef ma9a9ih93vWv65Kjs1akLfU4BTjcqO7PfsrlizQNXj91i+Hb651QFjhL2/ZfVeVWIozEg21mI uKEwEzYvlL3gIAAA== X-Env-Sender: Adam.Thomson.Opensource@diasemi.com X-Msg-Ref: server-13.tower-217.messagelabs.com!1481886303!70665870!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked From: Adam Thomson Date: Fri, 16 Dec 2016 11:05:02 +0000 Subject: [PATCH] ASoC: da7218: Set DAI output pin high impedance when not in use To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai CC: Support Opensource , , Message-ID: <20161216110502.849053FA9F@swsrvapps-01.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-ServerInfo: sw-ex-cashub01.diasemi.com, 9 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 16/12/2016 08:47:00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For TDM mode, the I2S data out line can be shared between mutliple codecs. In this scenario, only the active codec should be using the line, and all others should be high impedance. However, currently in the driver this configuration isn't set when capture is inactive, and the line remains driven. This patch updates the AIF_OUT widget to set the DAI output pin of the device as high impedance when not in use. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7218.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index c69e976..d256ebf 100644 --- a/sound/soc/codecs/da7218.c +++ b/sound/soc/codecs/da7218.c @@ -1634,7 +1634,8 @@ static int da7218_hp_pga_event(struct snd_soc_dapm_widget *w, SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD), /* DAI */ - SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0, DA7218_DAI_TDM_CTRL, + DA7218_DAI_OE_SHIFT, DA7218_NO_INVERT), SND_SOC_DAPM_AIF_IN("DAIIN", "Playback", 0, SND_SOC_NOPM, 0, 0), /* Output Mixers */ -- 1.9.3