From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761710AbcLPQ6M (ORCPT ); Fri, 16 Dec 2016 11:58:12 -0500 Received: from foss.arm.com ([217.140.101.70]:57104 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757429AbcLPQ6D (ORCPT ); Fri, 16 Dec 2016 11:58:03 -0500 Date: Fri, 16 Dec 2016 16:57:12 +0000 From: Mark Rutland To: Tony Lindgren Cc: Javier Martinez Canillas , Ivaylo Dimitrov , Pavel Machek , Arnd Bergmann , Aaro Koskinen , linux-kernel@vger.kernel.org, Linus Walleij , Russell King - ARM Linux , Sebastian Reichel , Ben Dooks , Pali =?utf-8?B?Um9ow6Fy?= , Robin Murphy , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs Message-ID: <20161216165711.GG20265@leverpostej> References: <1481749963-8664-1-git-send-email-pali.rohar@gmail.com> <201612161332.36406@pali> <5c56e769-76be-295e-b655-8431dde35370@osg.samsung.com> <201612161348.35917@pali> <1b779429-8ce4-a49b-38e4-573b28a7c05f@osg.samsung.com> <20161216154029.GF4920@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161216154029.GF4920@atomide.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 07:40:30AM -0800, Tony Lindgren wrote: > Yeah probaby best to add the empty chosen node to the ones that had > skeleton.dtsi removed. Yes please! We should probably update the comment in skeleton.dtsi to be more explicit. I had intended it to mean that chosen should always be present in the dts, but I worded it poorly. Thanks, Mark.