From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762152AbcLPX1S (ORCPT ); Fri, 16 Dec 2016 18:27:18 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:33030 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757463AbcLPX1L (ORCPT ); Fri, 16 Dec 2016 18:27:11 -0500 Date: Fri, 16 Dec 2016 23:27:08 +0000 From: Matthew Smith To: Laura Abbott Cc: greg@kroah.com, devel@driverdev.osuosl.org, arve@android.com, riandrews@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] staging: android: remove ION_IOC_SYNC Message-ID: <20161216232708.GA4028@steamroller> References: <20161216224246.3946-1-matthew.s3h@gmail.com> <7d594698-9b16-e296-1e84-10451e0ced4b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d594698-9b16-e296-1e84-10451e0ced4b@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 03:05:54PM -0800, Laura Abbott wrote: > The 'remove' from that TODO is more than just removing the code. > There's also an implicit 'replace it with something else'. The > work to do this is still ongoing (see some of my latest patches). > NAK for all 3 of these patches right now. Ah that makes a bit more sense. > The patches themselves looked structurally good. For your commit > message next time, explain why the code was being changed, not > just what was changed. Thank you for the advice, I'll remember that for next time :)