public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Scott Matheina <scott@matheina.com>
Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c
Date: Sat, 17 Dec 2016 23:46:59 -0800	[thread overview]
Message-ID: <20161218074659.GA29850@kroah.com> (raw)
In-Reply-To: <1482028973-10578-1-git-send-email-scott@matheina.com>

On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote:
> Signed-off-by: Scott Matheina <scott@matheina.com>

I can't take patches without any changelog text :(

> ---
>  drivers/staging/fbtft/fb_agm1264k-fl.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
> index a6e3af7..4e371ed 100644
> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
> @@ -186,8 +186,9 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
> 
>  		va_end(args);
>  		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,
> -			par->info->device, u8, buf, len, "%s: ", __func__);
> -	}
> +				  par->info->device, u8, buf, len,
> +				  "%s: ", __func__);
> +}

I don't think you did this correctly, do you?

  reply	other threads:[~2016-12-18  7:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-18  2:42 [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c Scott Matheina
2016-12-18  7:46 ` Greg KH [this message]
2016-12-18 17:43   ` Scott Matheina
2016-12-18 19:38     ` Scott Matheina
2016-12-19 11:48     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161218074659.GA29850@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=scott@matheina.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox