From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760263AbcLRK36 (ORCPT ); Sun, 18 Dec 2016 05:29:58 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33070 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757722AbcLRK35 (ORCPT ); Sun, 18 Dec 2016 05:29:57 -0500 Date: Sun, 18 Dec 2016 11:30:05 +0100 From: Greg KH To: devendra sharma Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, ansonjacob.aj@gmail.com, amitoj1606@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed check patch warnings Message-ID: <20161218103005.GA7863@kroah.com> References: <1482055995-31664-1-git-send-email-devendra.sharma9091@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482055995-31664-1-git-send-email-devendra.sharma9091@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 18, 2016 at 03:43:15PM +0530, devendra sharma wrote: > Fixed check patch warnings about multiple line dereferencing What does that mean? > > Signed-off-by: Devendra Sharma > --- > drivers/staging/comedi/drivers/cb_pcidas64.c | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c > index cb9c269..946c580 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidas64.c > +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c > @@ -1500,10 +1500,9 @@ static int alloc_and_init_dma_members(struct comedi_device *dev) > if (ao_cmd_is_supported(board)) { > devpriv->ao_buffer[i] = > dma_alloc_coherent(&pcidev->dev, > - DMA_BUFFER_SIZE, > - &devpriv-> > - ao_buffer_bus_addr[i], > - GFP_KERNEL); > + DMA_BUFFER_SIZE, > + &devpriv->ao_buffer_bus_addr[i], > + GFP_KERNEL); > if (!devpriv->ao_buffer[i]) > return -ENOMEM; > } > @@ -2476,18 +2475,15 @@ static int setup_channel_queue(struct comedi_device *dev, > for (i = 0; i < cmd->chanlist_len; i++) { > bits = 0; > /* set channel */ > - bits |= adc_chan_bits(CR_CHAN(cmd-> > - chanlist[i])); > + bits |= adc_chan_bits( > + CR_CHAN(cmd->chanlist[i])); That doesn't look better to me, does it to you? checkpatch is a guide, don't let it make you write code that isn't easy to understand. thanks, greg k-h