From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761876AbcLSAPQ (ORCPT ); Sun, 18 Dec 2016 19:15:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38006 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752902AbcLSANR (ORCPT ); Sun, 18 Dec 2016 19:13:17 -0500 From: Hans de Goede To: MyungJoo Ham , Chanwoo Choi Cc: linux-kernel@vger.kernel.org, Hans de Goede Subject: [PATCH 2/8] extcon: axp288: Remove usb_phy notification code Date: Mon, 19 Dec 2016 01:13:07 +0100 Message-Id: <20161219001313.13402-2-hdegoede@redhat.com> In-Reply-To: <20161219001313.13402-1-hdegoede@redhat.com> References: <20161219001313.13402-1-hdegoede@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 19 Dec 2016 00:13:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The usb_phy based intel-usb-phy code never got merged into the mainline kernel, so the devm_usb_get_phy() call will always fail, blocking the driver from loading. Since new drivers should use the generic-phy framework, not the old-style usb_phy stuff, keeping this around is not useful. Therefor this patch removes the usb_phy notification bits, which together with the patch to remove the platform_data dependency, makes this driver actually successfully probe on systems with an axp288 pmic. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-axp288.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c index a84fab8..3d5e84e 100644 --- a/drivers/extcon/extcon-axp288.c +++ b/drivers/extcon/extcon-axp288.c @@ -21,7 +21,6 @@ #include #include #include -#include #include #include #include @@ -116,7 +115,6 @@ struct axp288_extcon_info { int irq[EXTCON_IRQ_END]; struct extcon_dev *edev; struct notifier_block extcon_nb; - struct usb_phy *otg; }; /* Power up/down reason string array */ @@ -220,9 +218,6 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) gpiod_set_value(info->gpio_mux_cntl, vbus_attach ? EXTCON_GPIO_MUX_SEL_SOC : EXTCON_GPIO_MUX_SEL_PMIC); - - atomic_notifier_call_chain(&info->otg->notifier, - vbus_attach ? USB_EVENT_VBUS : USB_EVENT_NONE, NULL); } if (notify_charger) @@ -303,13 +298,6 @@ static int axp288_extcon_probe(struct platform_device *pdev) return ret; } - /* Get otg transceiver phy */ - info->otg = devm_usb_get_phy(&pdev->dev, USB_PHY_TYPE_USB2); - if (IS_ERR(info->otg)) { - dev_err(&pdev->dev, "failed to get otg transceiver\n"); - return PTR_ERR(info->otg); - } - /* Set up gpio control for USB Mux */ if (info->gpio_mux_cntl) { gpio = desc_to_gpio(info->gpio_mux_cntl); -- 2.9.3