From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762061AbcLSANa (ORCPT ); Sun, 18 Dec 2016 19:13:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44610 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755396AbcLSANV (ORCPT ); Sun, 18 Dec 2016 19:13:21 -0500 From: Hans de Goede To: MyungJoo Ham , Chanwoo Choi Cc: linux-kernel@vger.kernel.org, Hans de Goede Subject: [PATCH 5/8] extcon: axp288: Make a couple of messages dev_info instead of dev_dbg Date: Mon, 19 Dec 2016 01:13:10 +0100 Message-Id: <20161219001313.13402-5-hdegoede@redhat.com> In-Reply-To: <20161219001313.13402-1-hdegoede@redhat.com> References: <20161219001313.13402-1-hdegoede@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 19 Dec 2016 00:13:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These messages are helpful for the user to check if their charger is correctly detected, so make them dev_dbg instead of dev_info. Also add a new message to indicate when the vbus is disconnected / no cable is detected. Signed-off-by: Hans de Goede --- drivers/extcon/extcon-axp288.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c index ded0bd9..fc636f6 100644 --- a/drivers/extcon/extcon-axp288.c +++ b/drivers/extcon/extcon-axp288.c @@ -167,8 +167,10 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) } vbus_attach = (pwr_stat & PS_STAT_VBUS_PRESENT); - if (!vbus_attach) + if (!vbus_attach) { + dev_info(info->dev, "vbus/cable disconnected\n"); goto no_vbus; + } /* Check charger detection completion status */ ret = regmap_read(info->regmap, AXP288_BC_GLOBAL_REG, &cfg); @@ -187,15 +189,15 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) switch (chrg_type) { case DET_STAT_SDP: - dev_dbg(info->dev, "sdp cable is connected\n"); + dev_info(info->dev, "sdp cable is connected\n"); cable = EXTCON_CHG_USB_SDP; break; case DET_STAT_CDP: - dev_dbg(info->dev, "cdp cable is connected\n"); + dev_info(info->dev, "cdp cable is connected\n"); cable = EXTCON_CHG_USB_CDP; break; case DET_STAT_DCP: - dev_dbg(info->dev, "dcp cable is connected\n"); + dev_info(info->dev, "dcp cable is connected\n"); cable = EXTCON_CHG_USB_DCP; break; default: -- 2.9.3