From: Dan Carpenter <dan.carpenter@oracle.com>
To: Afonso Bordado <afonsobordado@az8.co>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Fix CamelCase styling issue
Date: Mon, 19 Dec 2016 14:52:32 +0300 [thread overview]
Message-ID: <20161219115232.GK8176@mwanda> (raw)
In-Reply-To: <20161218164650.pgrls6ead7jfgyj4@AYYLMAO>
On Sun, Dec 18, 2016 at 04:46:50PM +0000, Afonso Bordado wrote:
> Converts from CamelCase to the recommended style.
>
> Signed-off-by: Afonso Bordado <afonsobordado@az8.co>
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 3f42fa8..cf5cdd8 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -553,25 +553,25 @@ static void _nbu2ss_dma_unmap_single(
>
> /*-------------------------------------------------------------------------*/
> /* Endpoint 0 OUT Transfer (PIO) */
> -static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length)
> +static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *p_buf, u32 length)
> {
> u32 i;
> int nret = 0;
> - u32 iWordLength = 0;
> - union usb_reg_access *pBuf32 = (union usb_reg_access *)pBuf;
> + u32 i_word_length = 0;
> + union usb_reg_access *p_buf32 = (union usb_reg_access *)p_buf;
Remove the i_ and the p_ from the new name. We don't do that in the
linux kernel.
regards,
dan carpenter
prev parent reply other threads:[~2016-12-19 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-18 16:46 [PATCH] staging: emxx_udc: Fix CamelCase styling issue Afonso Bordado
2016-12-18 17:40 ` Joe Perches
2016-12-18 19:24 ` Afonso Bordado
2016-12-19 11:52 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219115232.GK8176@mwanda \
--to=dan.carpenter@oracle.com \
--cc=afonsobordado@az8.co \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox