[PATCH 1/1] x86/platform/intel/quark: add printf attribute to imr_self_test_result()

[PATCH 1/1] x86/platform/intel/quark: add printf attribute to imr_self_test_result()

[Nicolas Iooss]

__printf attributes help detecting issues in printf format strings at
compile time.

Even though imr_selftest.c is only compiled with
CONFIG_DEBUG_IMR_SELFTEST, gcc complains about a missing format
attribute when compiling allmodconfig with -Wmissing-format-attribute.
Silent this warning by adding the attribute.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
 arch/x86/platform/intel-quark/imr_selftest.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/platform/intel-quark/imr_selftest.c b/arch/x86/platform/intel-quark/imr_selftest.c
index f5bad40936ac..b8f562049cad 100644
--- a/arch/x86/platform/intel-quark/imr_selftest.c
+++ b/arch/x86/platform/intel-quark/imr_selftest.c
@@ -25,7 +25,8 @@
  * @fmt:	format string.
  * ...		variadic argument list.
  */
-static void __init imr_self_test_result(int res, const char *fmt, ...)
+static __printf(2, 3)
+void __init imr_self_test_result(int res, const char *fmt, ...)
 {
 	va_list vlist;
 
-- 
2.11.0

Re: [PATCH 1/1] x86/platform/intel/quark: add printf attribute to imr_self_test_result()

[Bryan O'Donoghue]

On 19/12/16 13:21, Nicolas Iooss wrote:
> __printf attributes help detecting issues in printf format strings at
> compile time.
>
> Even though imr_selftest.c is only compiled with
> CONFIG_DEBUG_IMR_SELFTEST, gcc complains about a missing format
> attribute when compiling allmodconfig with -Wmissing-format-attribute.
> Silent this warning by adding the attribute.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
>  arch/x86/platform/intel-quark/imr_selftest.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/intel-quark/imr_selftest.c b/arch/x86/platform/intel-quark/imr_selftest.c
> index f5bad40936ac..b8f562049cad 100644
> --- a/arch/x86/platform/intel-quark/imr_selftest.c
> +++ b/arch/x86/platform/intel-quark/imr_selftest.c
> @@ -25,7 +25,8 @@
>   * @fmt:	format string.
>   * ...		variadic argument list.
>   */
> -static void __init imr_self_test_result(int res, const char *fmt, ...)
> +static __printf(2, 3)
> +void __init imr_self_test_result(int res, const char *fmt, ...)
>  {
>  	va_list vlist;
>
>

since I wrote this code.

Acked-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>

cheers

---
bod

[tip:x86/urgent] x86/platform/intel/quark: Add printf attribute to imr_self_test_result()

[tip-bot for Nicolas Iooss]

Commit-ID:  9120cf4fd9ae77245ce9137869bcbd16575cc633
Gitweb:     http://git.kernel.org/tip/9120cf4fd9ae77245ce9137869bcbd16575cc633
Author:     Nicolas Iooss <nicolas.iooss_linux@m4x.org>
AuthorDate: Mon, 19 Dec 2016 14:21:44 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 20 Dec 2016 09:37:24 +0100

x86/platform/intel/quark: Add printf attribute to imr_self_test_result()

__printf() attributes help detecting issues in printf() format strings at
compile time.

Even though imr_selftest.c is only compiled with
CONFIG_DEBUG_IMR_SELFTEST=y, GCC complains about a missing format
attribute when compiling allmodconfig with -Wmissing-format-attribute.

Silence this warning by adding the attribute.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Acked-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20161219132144.4108-1-nicolas.iooss_linux@m4x.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/platform/intel-quark/imr_selftest.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/platform/intel-quark/imr_selftest.c b/arch/x86/platform/intel-quark/imr_selftest.c
index f5bad40..b8f5620 100644
--- a/arch/x86/platform/intel-quark/imr_selftest.c
+++ b/arch/x86/platform/intel-quark/imr_selftest.c
@@ -25,7 +25,8 @@
  * @fmt:	format string.
  * ...		variadic argument list.
  */
-static void __init imr_self_test_result(int res, const char *fmt, ...)
+static __printf(2, 3)
+void __init imr_self_test_result(int res, const char *fmt, ...)
 {
 	va_list vlist;