From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932632AbcLSPP3 (ORCPT ); Mon, 19 Dec 2016 10:15:29 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36016 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753663AbcLSPPS (ORCPT ); Mon, 19 Dec 2016 10:15:18 -0500 Date: Mon, 19 Dec 2016 23:15:15 +0800 From: Boqun Feng To: Colin Ian King Cc: Mark Rutland , linux-kernel@vger.kernel.org, "Paul E . McKenney " , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan Subject: Re: [RFC v2 4/5] rcu: Use for_each_leaf_node_cpu() in force_qs_rnp() Message-ID: <20161219151515.GP9728@tardis.cn.ibm.com> References: <20161215024204.28620-1-boqun.feng@gmail.com> <20161215024204.28620-5-boqun.feng@gmail.com> <20161215120459.GE21758@leverpostej> <20161215144242.GN9728@tardis.cn.ibm.com> <05a9953b-aaa4-6117-b120-85c12ad56ace@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05a9953b-aaa4-6117-b120-85c12ad56ace@canonical.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBJFFmlw017530 On Thu, Dec 15, 2016 at 02:51:36PM +0000, Colin Ian King wrote: > On 15/12/16 14:42, Boqun Feng wrote: > > On Thu, Dec 15, 2016 at 12:04:59PM +0000, Mark Rutland wrote: > >> On Thu, Dec 15, 2016 at 10:42:03AM +0800, Boqun Feng wrote: > >>> ->qsmask of an RCU leaf node is usually more sparse than the > >>> corresponding cpu_possible_mask. So replace the > >>> for_each_leaf_node_possible_cpu() in force_qs_rnp() with > >>> for_each_leaf_node_cpu() to save several checks. > >>> > >>> [Note we need to use "1UL << bit" instead of "1 << bit" to generate the > >>> corresponding mask for a bit because @mask is unsigned long, this was > >>> spotted by Colin Ian King and CoverityScan in > >>> a previous version of this patch.] > >> > >> Nit: This note can go now that we use leaf_node_cpu_bit(). ;) > >> > > > > I kinda keep this here for honoring the effort of finding out this bug > > from Colin, but yes, it's no longer needed here for the current code. > > Yep, remove it. > Paul, here is a modified version of this patch, what I only did is removing this note. Besides I rebased the whole series on the current rcu/dev branch of -rcu tree, on this very commit: 8e9b2521b18a ("doc: Quick-Quiz answers are now inline") And I put the latest version at git://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git leaf-node If you thought it's better, I could send a v3 ;-) Regards, Boqun ------------------------>8 From: Boqun Feng Date: Thu, 8 Dec 2016 23:21:11 +0800 Subject: [PATCH v2.1 4/5] rcu: Use for_each_leaf_node_cpu() in force_qs_rnp() ->qsmask of an RCU leaf node is usually more sparse than the corresponding cpu_possible_mask. So replace the for_each_leaf_node_possible_cpu() in force_qs_rnp() with for_each_leaf_node_cpu() to save several checks. Signed-off-by: Boqun Feng --- kernel/rcu/tree.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 4ea4496f4ecc..c2b753fb7f09 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3046,13 +3046,11 @@ static void force_qs_rnp(struct rcu_state *rsp, continue; } } - for_each_leaf_node_possible_cpu(rnp, cpu) { - unsigned long bit = leaf_node_cpu_bit(rnp, cpu); - if ((rnp->qsmask & bit) != 0) { - if (f(per_cpu_ptr(rsp->rda, cpu), isidle, maxj)) - mask |= bit; - } - } + + for_each_leaf_node_cpu(rnp, rnp->qsmask, cpu) + if (f(per_cpu_ptr(rsp->rda, cpu), isidle, maxj)) + mask |= leaf_node_cpu_bit(rnp, cpu); + if (mask != 0) { /* Idle/offline CPUs, report (releases rnp->lock. */ rcu_report_qs_rnp(mask, rsp, rnp, rnp->gpnum, flags); -- 2.10.2