From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Jiandi An <anjiandi@codeaurora.org>,
peterhuewe@gmx.de, tpmdd@selhorst.net,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm, tpm_crb: Handle 64-bit resource in crb_check_resource()
Date: Mon, 19 Dec 2016 09:22:01 -0700 [thread overview]
Message-ID: <20161219162201.GA10988@obsidianresearch.com> (raw)
In-Reply-To: <20161219135624.2e7okpswnbqbvic7@intel.com>
On Mon, Dec 19, 2016 at 03:56:24PM +0200, Jarkko Sakkinen wrote:
> On Sun, Dec 18, 2016 at 10:20:53PM -0600, Jiandi An wrote:
> > crb_check_resource() in TPM CRB driver calls
> > acpi_dev_resource_memory() which only handles 32-bit resources.
> > Adding a call to acpi_dev_resource_address_space() in TPM CRB
> > driver which handles 64-bit resources.
> >
> > Signed-off-by: Jiandi An <anjiandi@codeaurora.org>
>
> 1. Is there a platform in existence where this change fixes a problem?
> 2. What is difference between "memory" and "address space" conceptually?
> Just wondering why 32-bit stuff is "memory" and 64-bit stuff is
> "address space". Could there be a one function that would work both
> for 32-bit and 64-bit cases?
>
> Yeah, I do not know this API too well. That's why I'm asking.
If this is the right thing it also needs to be done in tpm_tis.
I will point out that this driver only works with memory, so using a
generic decoder without checking for IO maps may not be correct..
Jason
next prev parent reply other threads:[~2016-12-19 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 4:20 [PATCH] tpm, tpm_crb: Handle 64-bit resource in crb_check_resource() Jiandi An
2016-12-19 13:56 ` Jarkko Sakkinen
2016-12-19 16:22 ` Jason Gunthorpe [this message]
2016-12-20 6:19 ` [tpmdd-devel] " Jiandi An
2017-01-03 17:11 ` Jarkko Sakkinen
2017-01-03 18:27 ` Jarkko Sakkinen
2017-01-09 18:43 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219162201.GA10988@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=anjiandi@codeaurora.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).