public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Martin Steigerwald <martin.steigerwald@teamix.de>
Cc: Ingo Molnar <mingo@kernel.org>, Andrew Morton <akpm@osdl.org>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	Jay Lan <jlan@engr.sgi.com>,
	Martin Steigerwald <martin@lichtvoll.de>,
	Gerlof Langeveld <gerlof.langeveld@atoptool.nl>,
	Marc Haber <mh+debian-packages@zugschlus.de>,
	Ben Hutchings <ben@decadent.org.uk>,
	Balbir Singh <bsingharora@gmail.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly
Date: Mon, 19 Dec 2016 18:25:49 +0100	[thread overview]
Message-ID: <20161219172549.GK3107@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <5967400.cFS0L5jxeH@merkaba>


On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote:
> 
> 2) When using the NETLINK inface, the command TASKSTATS_CMD_GET 
> consequently returns -EINVAL.
> 
> The code that is used by the atopacctd daemon is based on the demo code 
> 'getdelays.c' that can be found in the kernel source code tree
> (..../linux/Documentation/accounting/getdelays.c). Also this 'getdelays' 
> program does not work any more (also -EINVAL on the same call)
> with the newer kernels. I really spent a lot of time on this issue to 
> get the code running (there are many places in the kernel code where
> -EINVAL for this call can be given), but I did not succeed. It is really 
> an incompatibility introduced by the kernel code.
> It would be nice if the kernel maintainers provide a working version of 
> the getdelays program in the kernel source tree.
> 
> I only experience this problem on Debian8 with a 4.8 kernel (virtual 
> machine with 4 cores).
> On CentOS7 with a 4.8 kernel it works fine (physical machine with 4 cores).
> 
> I will anyhow adapt atopacctd for this issue that it detects and logs 
> the -EINVAL and terminates.
> The current version of atopacctd keeps running which is not useful at all.
> 
> 
> I reported this as:
> 
> Bug 190711 - Process accounting: Using the NETLINK inface, the command 
> TASKSTATS_CMD_GET returns -EINVAL
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=190711


Ben Hutchings reports:

"It looks like the taskstats bug was introduced by 513e3d2d11c9 as that
means cpumask_parse() may not initialise as many bits as
cpumask_subset() compares"

  parent reply	other threads:[~2016-12-19 17:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19 12:06 [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly Martin Steigerwald
2016-12-19 13:19 ` Peter Zijlstra
2016-12-19 13:50   ` Martin Steigerwald
2016-12-19 14:02     ` Peter Zijlstra
2016-12-19 17:25 ` Peter Zijlstra [this message]
2017-02-06 10:39   ` Martin Steigerwald
2017-02-06 16:20     ` Tejun Heo
2017-02-06 18:24       ` [PATCH] cpumask: use nr_cpumask_bits for parsing functions Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2017-02-10 21:56 [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly Dmitry Romanov
2017-02-12 15:44 ` Dmitry Romanov
2017-03-08 11:14   ` Richard Genoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161219172549.GK3107@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@osdl.org \
    --cc=ben@decadent.org.uk \
    --cc=bsingharora@gmail.com \
    --cc=gerlof.langeveld@atoptool.nl \
    --cc=jlan@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.steigerwald@teamix.de \
    --cc=martin@lichtvoll.de \
    --cc=mh+debian-packages@zugschlus.de \
    --cc=mingo@elte.hu \
    --cc=mingo@kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox