From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Paul Turner <pjt@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics
Date: Tue, 20 Dec 2016 14:22:03 +0100 [thread overview]
Message-ID: <20161220132203.GD2895@var.home> (raw)
In-Reply-To: <cfa3d75d-b0b4-a785-7a24-3d6720e697bb@arm.com>
Dietmar Eggemann, on Tue 20 Dec 2016 14:04:34 +0100, wrote:
> On 12/20/2016 12:45 AM, Samuel Thibault wrote:
> >Paul Turner, on Mon 19 Dec 2016 15:32:15 -0800, wrote:
> >>On Mon, Dec 19, 2016 at 3:29 PM, Samuel Thibault
> >><samuel.thibault@ens-lyon.org> wrote:
> >>>Paul Turner, on Mon 19 Dec 2016 15:26:19 -0800, wrote:
>
> [...]
>
> >>The MIN_SHARES you are seeing here is overloaded.
> >>In the unscaled case this needs to be MIN_SHARES, and in the scaled
> >>case, the subdivision of the scaled values must still be >=2.
> >
> >Ok, now I understand. I have to say this overloading is confusing.
> >
> >Samuel
>
> this had been already discussed back in August when I posted the original
> patch.
But that doesn't show up in the source code or git history. One
shouldn't have to dig mailing lists to get code comments :)
Samuel
prev parent reply other threads:[~2016-12-20 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 22:40 [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Samuel Thibault
2016-12-19 22:44 ` Paul Turner
2016-12-19 23:07 ` Samuel Thibault
2016-12-19 23:26 ` Paul Turner
2016-12-19 23:29 ` Samuel Thibault
2016-12-19 23:32 ` Paul Turner
2016-12-19 23:45 ` Samuel Thibault
2016-12-20 13:04 ` Dietmar Eggemann
2016-12-20 13:15 ` Peter Zijlstra
2017-01-11 11:29 ` Dietmar Eggemann
2017-01-14 12:48 ` [tip:sched/core] sched/fair: Explain why MIN_SHARES isn't scaled in calc_cfs_shares() tip-bot for Dietmar Eggemann
2016-12-20 13:22 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220132203.GD2895@var.home \
--to=samuel.thibault@ens-lyon.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).