From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941264AbcLVN3M (ORCPT ); Thu, 22 Dec 2016 08:29:12 -0500 Received: from mail.kernel.org ([198.145.29.136]:59078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752729AbcLVN3K (ORCPT ); Thu, 22 Dec 2016 08:29:10 -0500 Date: Thu, 22 Dec 2016 10:19:26 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 1/3] perf sched timehist: Enlarge default comm_width Message-ID: <20161222131925.GB3717@kernel.org> References: <20161222060350.17655-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161222060350.17655-1-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Dec 22, 2016 at 03:03:48PM +0900, Namhyung Kim escreveu: > Current default value is 20 but it's easily changed to a bigger value as > task has a long name and different tid and pid. And it makes the output > not aligned. So change it to have a large value as summary shows. So you're doing multiple things here: 1) making more places honour the comm_width (header) 2) changing its default from 20 to 30 and due to this, removing the setting to 30 done at timehist_print_summary I'll break it into two to reflect that. - Arnaldo > Signed-off-by: Namhyung Kim > --- > tools/perf/builtin-sched.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c > index c1c07bfe132c..5052caa91caa 100644 > --- a/tools/perf/builtin-sched.c > +++ b/tools/perf/builtin-sched.c > @@ -1775,7 +1775,7 @@ static u64 perf_evsel__get_time(struct perf_evsel *evsel, u32 cpu) > return r->last_time[cpu]; > } > > -static int comm_width = 20; > +static int comm_width = 30; > > static char *timehist_get_commstr(struct thread *thread) > { > @@ -1817,7 +1817,7 @@ static void timehist_header(struct perf_sched *sched) > printf(" "); > } > > - printf(" %-20s %9s %9s %9s", > + printf(" %-*s %9s %9s %9s", comm_width, > "task name", "wait time", "sch delay", "run time"); > > printf("\n"); > @@ -1830,7 +1830,8 @@ static void timehist_header(struct perf_sched *sched) > if (sched->show_cpu_visual) > printf(" %*s ", ncpus, ""); > > - printf(" %-20s %9s %9s %9s\n", "[tid/pid]", "(msec)", "(msec)", "(msec)"); > + printf(" %-*s %9s %9s %9s\n", comm_width, > + "[tid/pid]", "(msec)", "(msec)", "(msec)"); > > /* > * separator > @@ -1840,7 +1841,7 @@ static void timehist_header(struct perf_sched *sched) > if (sched->show_cpu_visual) > printf(" %.*s ", ncpus, graph_dotted_line); > > - printf(" %.20s %.9s %.9s %.9s", > + printf(" %.*s %.9s %.9s %.9s", comm_width, > graph_dotted_line, graph_dotted_line, graph_dotted_line, > graph_dotted_line); > > @@ -2626,9 +2627,6 @@ static void timehist_print_summary(struct perf_sched *sched, > > memset(&totals, 0, sizeof(totals)); > > - if (comm_width < 30) > - comm_width = 30; > - > if (sched->idle_hist) { > printf("\nIdle-time summary\n"); > printf("%*s parent sched-out ", comm_width, "comm"); > -- > 2.10.0