From: Jiri Olsa <jolsa@redhat.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@kernel.org>, Wang Nan <wangnan0@huawei.com>,
linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.com>
Subject: Re: [PATCH] tools build: replace $(CC) -E with $(CPP) for pre-processing
Date: Fri, 23 Dec 2016 11:59:47 +0100 [thread overview]
Message-ID: <20161223105947.GA5944@krava> (raw)
In-Reply-To: <1482468402-7782-1-git-send-email-yamada.masahiro@socionext.com>
On Fri, Dec 23, 2016 at 01:46:42PM +0900, Masahiro Yamada wrote:
> The top-level Makefile defines:
>
> CPP = $(CC) -E
hum, so that'd work for running from top level, but I guess
it fails for compiling from other places..? like tools/perf
jirka
>
> So, $(CC) -E can be replaced with $(CPP) and this makes more sense
> for pre-processing.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> tools/build/Makefile.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 99c0ccd..4a0ec5c 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -65,7 +65,7 @@ quiet_cmd_cxx_o_c = CXX $@
> cmd_cxx_o_c = $(CXX) $(cxx_flags) -c -o $@ $<
>
> quiet_cmd_cpp_i_c = CPP $@
> - cmd_cpp_i_c = $(CC) $(c_flags) -E -o $@ $<
> + cmd_cpp_i_c = $(CPP) $(c_flags) -o $@ $<
>
> quiet_cmd_cc_s_c = AS $@
> cmd_cc_s_c = $(CC) $(c_flags) -S -o $@ $<
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-12-23 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 4:46 [PATCH] tools build: replace $(CC) -E with $(CPP) for pre-processing Masahiro Yamada
2016-12-23 10:59 ` Jiri Olsa [this message]
2016-12-24 6:24 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223105947.GA5944@krava \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=wangnan0@huawei.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox