From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1030345AbcLWK7x (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Dec 2016 05:59:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40270 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1030315AbcLWK7u (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Dec 2016 05:59:50 -0500
Date: Fri, 23 Dec 2016 11:59:47 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>, Wang Nan <wangnan0@huawei.com>,
        linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.com>
Subject: Re: [PATCH] tools build: replace $(CC) -E with $(CPP) for
 pre-processing
Message-ID: <20161223105947.GA5944@krava>
References: <1482468402-7782-1-git-send-email-yamada.masahiro@socionext.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1482468402-7782-1-git-send-email-yamada.masahiro@socionext.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 23 Dec 2016 10:59:50 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 23, 2016 at 01:46:42PM +0900, Masahiro Yamada wrote:
> The top-level Makefile defines:
> 
>   CPP             = $(CC) -E

hum, so that'd work for running from top level, but I guess
it fails for compiling from other places..? like tools/perf

jirka

> 
> So, $(CC) -E can be replaced with $(CPP) and this makes more sense
> for pre-processing.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  tools/build/Makefile.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 99c0ccd..4a0ec5c 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -65,7 +65,7 @@ quiet_cmd_cxx_o_c = CXX      $@
>        cmd_cxx_o_c = $(CXX) $(cxx_flags) -c -o $@ $<
>  
>  quiet_cmd_cpp_i_c = CPP      $@
> -      cmd_cpp_i_c = $(CC) $(c_flags) -E -o $@ $<
> +      cmd_cpp_i_c = $(CPP) $(c_flags) -o $@ $<
>  
>  quiet_cmd_cc_s_c = AS       $@
>        cmd_cc_s_c = $(CC) $(c_flags) -S -o $@ $<
> -- 
> 2.7.4
>